Implement MediaMetadata artwork in Blink

Implement MediaMetadata artwork in Blink

This CL adds artwork in MediaMetadata in Blink.

The artwork info will be propagated to the browser through MediaMetadata, and we will finally fetch the image and display it in media notification.

Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129

Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/

BUG=616411
Committed: https://crrev.com/8ce5f8dc4a4337cd0d486504413ea0f3be17ba85
Cr-Commit-Position: refs/heads/master@{#398922}

[Zhiqiang Zhang (Slow), 2016-05-25 13:48:53]

Description was changed from

==========
Implement MediaSession artwork in Blink

BUG=
==========

to

==========
Implement MediaMetadata artwork in Blink

BUG=
==========

[Zhiqiang Zhang (Slow), 2016-05-31 14:50:08]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-05-31 16:41:50]

It's only a first pass because my brain is fried thanks to jetlag.

In addition of the comments below:
- I think you should open a bug for this (if there isn't already).
- You might want to give more context in the description like adding links to
related CLs.
- Having some agreement on the spec side would be good. Do you need help with
that?

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtwork.cpp (right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtwork.cpp:22: m_data.src =
src;
remove the temporary variable?

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl (left):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:6:
event.respondWith(fetch(event.request));
to avoid the fake copy, you can pass --no-find-copies to git cl upload.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl (right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl:15: readonly
attribute sequence<MediaArtwork> artworks;
I wonder if that should be a FrozenArray<MediaArtwork>
(http://heycam.github.io/webidl/#idl-frozen-array).

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl:11:
sequence<MediaArtworkInit>? artworks;
The optional marker (ie. "?") doesn't really apply to dictionaries because all
values are optional unless stated otherwise. I would suggest to just remove the
"?".

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h
(right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:9:
#include "public/platform/WebVector.h"
-WebVector.h?

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h
(right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h:10:
#include "wtf/Vector.h"
public/platform/WebVector.h instead?

[Zhiqiang Zhang (Slow), 2016-06-01 19:31:26]

Patchset #3 (id:40001) has been deleted

[Zhiqiang Zhang (Slow), 2016-06-01 19:37:18]

Description was changed from

==========
Implement MediaMetadata artwork in Blink

BUG=
==========

to

==========
Implement MediaMetadata artwork in Blink

This CL adds artwork in MediaMetadata in Blink.

The artwork info will be propagated to the browser through MediaMetadata, and we
will finally fetch the image and display it in media notification.

Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129

Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/

BUG=616411
==========

[Zhiqiang Zhang (Slow), 2016-06-01 19:40:37]

Patchset #3 (id:60001) has been deleted

[Zhiqiang Zhang (Slow), 2016-06-01 19:40:57]

PTAL. Addressed comments.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtwork.cpp (right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtwork.cpp:22: m_data.src =
src;
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> remove the temporary variable?

Done.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl (left):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:6:
event.respondWith(fetch(event.request));
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> to avoid the fake copy, you can pass --no-find-copies to git cl upload.

Done.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl (right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl:15: readonly
attribute sequence<MediaArtwork> artworks;
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> I wonder if that should be a FrozenArray<MediaArtwork>
> (http://heycam.github.io/webidl/#idl-frozen-array).

Done.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl:11:
sequence<MediaArtworkInit>? artworks;
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> The optional marker (ie. "?") doesn't really apply to dictionaries because all
> values are optional unless stated otherwise. I would suggest to just remove
the
> "?".

Done.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h
(right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> 2016

Done.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:9:
#include "public/platform/WebVector.h"
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> -WebVector.h?

Done.

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h
(right):

https://codereview.chromium.org/2013813002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h:10:
#include "wtf/Vector.h"
On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote:
> public/platform/WebVector.h instead?

Done.

[haraken, 2016-06-02 01:08:29]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-06-02 01:08:30]

Drive-by.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl (right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl:5: [

Add a link to the spec.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:5:
dictionary MediaArtworkInit {

Add a link to the spec.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:13:
struct WebMediaArtwork {

Nit: struct => class

[mlamouri (slow - plz ping), 2016-06-02 16:10:07]

Looks good! You might want to add some LayoutTests though :)

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp (right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp:29:
m_artworks.append(artwork);
Why do you need `m_artworks` compared to m_data.artworks?

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.h (right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.h:30:
HeapVector<Member<MediaArtwork>> artworks() const;
I think you should return a const ref.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl:11:
FrozenArray<MediaArtworkInit> artworks;
As discussed in the spec bug, I think we could make this a normal array.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:13:
struct WebMediaArtwork {
On 2016/06/02 at 01:08:30, haraken wrote:
> Nit: struct => class

Why class? We have other exposed struct like WebNotificationData or
WebMediaMetadata. My understanding was that struct should be used if the object
was simply a property bag so we don't need to add accessors.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h:16:
public:
I don't think you need 'public' here.

[Zhiqiang Zhang (Slow), 2016-06-03 16:07:31]

PTAL. Addressed reviewers' comments, and added layout tests as well.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl (right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl:5: [
On 2016/06/02 01:08:30, haraken wrote:
> 
> Add a link to the spec.

The spec change has not landed yet. Added a TODO so I won't forget when landing
it.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:5:
dictionary MediaArtworkInit {
On 2016/06/02 01:08:30, haraken wrote:
> 
> Add a link to the spec.

Ditto.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp (right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp:29:
m_artworks.append(artwork);
On 2016/06/02 16:10:06, Mounir Lamouri (slow) wrote:
> Why do you need `m_artworks` compared to m_data.artworks?

Done. Now I don't save a copy of WebMediaMetadata in MediaMetadata.

The conversion only happens when it's needed (setMetadata()).

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.h (right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.h:30:
HeapVector<Member<MediaArtwork>> artworks() const;
On 2016/06/02 16:10:06, Mounir Lamouri (slow) wrote:
> I think you should return a const ref.

Done.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl:11:
FrozenArray<MediaArtworkInit> artworks;
On 2016/06/02 16:10:06, Mounir Lamouri (slow) wrote:
> As discussed in the spec bug, I think we could make this a normal array.

Done. But I think we should use sequence<>/FrozenArray<> in the end.  Arrays are
replaced by FrozenArrays in WebIDL v2. There no reason we use both old and new
WebIDL.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h:13:
struct WebMediaArtwork {
On 2016/06/02 16:10:07, Mounir Lamouri (slow) wrote:
> On 2016/06/02 at 01:08:30, haraken wrote:
> > Nit: struct => class
> 
> Why class? We have other exposed struct like WebNotificationData or
> WebMediaMetadata. My understanding was that struct should be used if the
object
> was simply a property bag so we don't need to add accessors.

Keeping struct.

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h
(right):

https://codereview.chromium.org/2013813002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h:16:
public:
On 2016/06/02 16:10:07, Mounir Lamouri (slow) wrote:
> I don't think you need 'public' here.

Done.

[mlamouri (slow - plz ping), 2016-06-08 13:06:18]

sgtm. Let's see how the spec discussion goes. We can always land this and
iterate if needed.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl (left):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:5: module
cc.mojom;
nit: maybe pass --no-find-copies to avoid fake copies?

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.h (right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.h:33: operator
WebMediaMetadata() const;
explicit operator maybe?

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl:11:
MediaArtworkInit[] artworks = [];
I agree that we should use sequence<> if that's valid here.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h
(right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h:19:
WebVector<WebMediaArtwork> artworks;
nit: rename to `artwork` following the spec change?

[mlamouri (slow - plz ping), 2016-06-09 10:54:03]

I talked to foolip@ and we agreed it's fine to lgtm and land this and iterate
based on what the spec discussion leads to. This is all behind a flag so there
is no point keeping this CL pending.

[mlamouri (slow - plz ping), 2016-06-09 10:54:23]

haraken@, can you look at the V8Binding.h change?

[haraken, 2016-06-09 11:17:44]

LGTM

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl (right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl:5: //
TODO(zqzhang): add link to the spec.

Don't we have a spec yet?

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:5: //
TODO(zqzhang): add link to the spec.

Ditto.

[Zhiqiang Zhang (Slow), 2016-06-09 15:25:15]

Patchset #7 (id:160001) has been deleted

[Zhiqiang Zhang (Slow), 2016-06-09 15:30:13]

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl (right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaArtwork.idl:5: //
TODO(zqzhang): add link to the spec.
On 2016/06/09 11:17:44, haraken wrote:
> 
> Don't we have a spec yet?

Added link to the spec change proposal.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl (left):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:5: module
cc.mojom;
On 2016/06/08 13:06:17, Mounir Lamouri (slow) wrote:
> nit: maybe pass --no-find-copies to avoid fake copies?

Done.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaArtworkInit.idl:5: //
TODO(zqzhang): add link to the spec.
On 2016/06/09 11:17:44, haraken wrote:
> 
> Ditto.

Added link to the spec change proposal.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaMetadata.h (right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaMetadata.h:33: operator
WebMediaMetadata() const;
On 2016/06/08 13:06:18, Mounir Lamouri (slow) wrote:
> explicit operator maybe?

Done.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl
(right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl:11:
MediaArtworkInit[] artworks = [];
On 2016/06/08 13:06:18, Mounir Lamouri (slow) wrote:
> I agree that we should use sequence<> if that's valid here.

Done.

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h
(right):

https://codereview.chromium.org/2013813002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h:19:
WebVector<WebMediaArtwork> artworks;
On 2016/06/08 13:06:18, Mounir Lamouri (slow) wrote:
> nit: rename to `artwork` following the spec change?

Done.

[Zhiqiang Zhang (Slow), 2016-06-09 15:30:21]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-06-09 15:30:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2013813002/#ps180001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-06-09 15:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013813002/180001

[commit-bot: I haz the power, 2016-06-09 17:10:02]

Description was changed from

==========
Implement MediaMetadata artwork in Blink

This CL adds artwork in MediaMetadata in Blink.

The artwork info will be propagated to the browser through MediaMetadata, and we
will finally fetch the image and display it in media notification.

Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129

Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/

BUG=616411
==========

to

==========
Implement MediaMetadata artwork in Blink

This CL adds artwork in MediaMetadata in Blink.

The artwork info will be propagated to the browser through MediaMetadata, and we
will finally fetch the image and display it in media notification.

Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129

Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/

BUG=616411
==========

[commit-bot: I haz the power, 2016-06-09 17:10:04]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2016-06-09 17:10:23]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 17:11:54]

Description was changed from

==========
Implement MediaMetadata artwork in Blink

This CL adds artwork in MediaMetadata in Blink.

The artwork info will be propagated to the browser through MediaMetadata, and we
will finally fetch the image and display it in media notification.

Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129

Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/

BUG=616411
==========

to

==========
Implement MediaMetadata artwork in Blink

This CL adds artwork in MediaMetadata in Blink.

The artwork info will be propagated to the browser through MediaMetadata, and we
will finally fetch the image and display it in media notification.

Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129

Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/

BUG=616411

Committed: https://crrev.com/8ce5f8dc4a4337cd0d486504413ea0f3be17ba85
Cr-Commit-Position: refs/heads/master@{#398922}
==========

[commit-bot: I haz the power, 2016-06-09 17:11:56]

Patchset 7 (id:??) landed as
https://crrev.com/8ce5f8dc4a4337cd0d486504413ea0f3be17ba85
Cr-Commit-Position: refs/heads/master@{#398922}