third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h - Issue 2013813002: Implement MediaMetadata artwork in Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/mediasession/WebMediaArtwork.h

Issue 2013813002: Implement MediaMetadata artwork in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebMediaArtwork_h

	6 #define WebMediaArtwork_h

	7

	8 #include "public/platform/WebString.h"

	9

	10 namespace blink {

	11

	12 // Representation of MediaArtwork interface to the content layer.

	13 struct WebMediaArtwork {
	haraken 2016/06/02 01:08:30 Nit: struct => class Nit: struct => class mlamouri (slow - plz ping) 2016/06/02 16:10:07 Why class? We have other exposed struct like WebNo Show quoted text On 2016/06/02 at 01:08:30, haraken wrote: > Nit: struct => class Why class? We have other exposed struct like WebNotificationData or WebMediaMetadata. My understanding was that struct should be used if the object was simply a property bag so we don't need to add accessors. Zhiqiang Zhang (Slow) 2016/06/03 16:07:31 Keeping struct. Show quoted text On 2016/06/02 16:10:07, Mounir Lamouri (slow) wrote: > On 2016/06/02 at 01:08:30, haraken wrote: > > Nit: struct => class > > Why class? We have other exposed struct like WebNotificationData or > WebMediaMetadata. My understanding was that struct should be used if the object > was simply a property bag so we don't need to add accessors. Keeping struct.
	14 WebString src;

	15 WebString sizes;

	16 WebString type;

	17 };

	18

	19 }

	20

	21 #endif // WebMediaArtwork_h

OLD	NEW