third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl - Issue 2013813002: Implement MediaMetadata artwork in Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediasession/MediaMetadataInit.idl

Issue 2013813002: Implement MediaMetadata artwork in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://mediasession.spec.whatwg.org/#the-mediametadata-interface	5 // https://mediasession.spec.whatwg.org/#the-mediametadata-interface

6	6

7 dictionary MediaMetadataInit {	7 dictionary MediaMetadataInit {

8 DOMString title = "";	8 DOMString title = "";

9 DOMString artist = "";	9 DOMString artist = "";

10 DOMString album = "";	10 DOMString album = "";

	11 sequence<MediaArtworkInit>? artworks;
	mlamouri (slow - plz ping) 2016/05/31 16:41:50 The optional marker (ie. "?") doesn't really apply The optional marker (ie. "?") doesn't really apply to dictionaries because all values are optional unless stated otherwise. I would suggest to just remove the "?". Zhiqiang Zhang (Slow) 2016/06/01 19:40:57 Done. Show quoted text On 2016/05/31 16:41:50, Mounir Lamouri (slow) wrote: > The optional marker (ie. "?") doesn't really apply to dictionaries because all > values are optional unless stated otherwise. I would suggest to just remove the > "?". Done.
11 };	12 };

OLD	NEW