third_party/WebKit/Source/modules/mediasession/MediaSession.cpp - Issue 2013813002: Implement MediaMetadata artwork in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

Issue 2013813002: Implement MediaMetadata artwork in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

diff --git a/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

index dec7b3c455484286115e1487cf609eca5b652e9d..feaab354c71d49276a48f5937afd2fc696a66604 100644

--- a/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

+++ b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp

@@ -57,8 +57,12 @@ ScriptPromise MediaSession::deactivate(ScriptState* scriptState)

void MediaSession::setMetadata(MediaMetadata* metadata)

{

m_metadata = metadata;

- m_webMediaSession->setMetadata(m_metadata ? m_metadata->data() : nullptr);

+ if (metadata) {

+ WebMediaMetadata webMetadata = (WebMediaMetadata) *metadata;

+ m_webMediaSession->setMetadata(&webMetadata);

+ } else {

+ m_webMediaSession->setMetadata(nullptr);

+ }

}

MediaMetadata* MediaSession::metadata() const