Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012523002: DevTools: migrate off ASSERT in inspector protocol. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate off ASSERT in inspector protocol. BUG=580337 Committed: https://crrev.com/3905c12981492102e63165a7b4e315dc6983922f Cr-Commit-Position: refs/heads/master@{#395953}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
4 years, 7 months ago (2016-05-24 19:10:06 UTC) #2
pfeldman
Updated
4 years, 7 months ago (2016-05-24 19:17:43 UTC) #3
dgozman
lgtm
4 years, 7 months ago (2016-05-24 19:20:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012523002/40001
4 years, 7 months ago (2016-05-25 17:45:51 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 19:12:47 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 19:14:30 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3905c12981492102e63165a7b4e315dc6983922f
Cr-Commit-Position: refs/heads/master@{#395953}

Powered by Google App Engine
This is Rietveld 408576698