Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 2012523002: DevTools: migrate off ASSERT in inspector protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
index 3738af2fa4ecdcbc72fcd50f58ef7b2fa54be277..19a92d0d053dc5a7bfec22db8b1312de18719b8f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
@@ -1014,10 +1014,7 @@ void V8DebuggerAgentImpl::asyncTaskStarted(void* task)
if (!m_maxAsyncCallStackDepth)
return;
-#if ENABLE(ASSERT)
m_currentTasks.append(task);
-#endif
-
V8StackTraceImpl* stack = m_asyncTaskStacks.get(task);
// Needs to support following order of events:
// - asyncTaskScheduled
@@ -1037,10 +1034,8 @@ void V8DebuggerAgentImpl::asyncTaskFinished(void* task)
if (!m_currentStacks.size())
return;
-#if ENABLE(ASSERT)
DCHECK(m_currentTasks.last() == task);
m_currentTasks.removeLast();
-#endif
m_currentStacks.removeLast();
if (!m_recurringTasks.contains(task))
@@ -1052,10 +1047,7 @@ void V8DebuggerAgentImpl::allAsyncTasksCanceled()
m_asyncTaskStacks.clear();
m_recurringTasks.clear();
m_currentStacks.clear();
-
-#if ENABLE(ASSERT)
m_currentTasks.clear();
-#endif
}
void V8DebuggerAgentImpl::setBlackboxPatterns(ErrorString* errorString, std::unique_ptr<protocol::Array<String16>> patterns)
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698