third_party/WebKit/Source/platform/inspector_protocol/Values.cpp - Issue 2012523002: DevTools: migrate off ASSERT in inspector protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

Issue 2012523002: DevTools: migrate off ASSERT in inspector protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp b/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

index c2359daa82b4f3d53a58567d0477c1c50198d15b..9cc1ca51bf484a7c751f35e528f56111683656cd 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

@@ -345,7 +345,7 @@ void ListValue::pushValue(std::unique_ptr<protocol::Value> value)

protocol::Value* ListValue::at(size_t index)

{

- ASSERT_WITH_SECURITY_IMPLICATION(index < m_data.size());

+ DCHECK_LT(index, m_data.size());

return m_data[index];

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | no next file with comments »