Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/platform/inspector_protocol/Values.cpp

Issue 2012523002: DevTools: migrate off ASSERT in inspector protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/inspector_protocol/Values.h" 5 #include "platform/inspector_protocol/Values.h"
6 6
7 #include "platform/inspector_protocol/Parser.h" 7 #include "platform/inspector_protocol/Parser.h"
8 #include "platform/inspector_protocol/String16.h" 8 #include "platform/inspector_protocol/String16.h"
9 #include <cmath> 9 #include <cmath>
10 10
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 } 338 }
339 339
340 void ListValue::pushValue(std::unique_ptr<protocol::Value> value) 340 void ListValue::pushValue(std::unique_ptr<protocol::Value> value)
341 { 341 {
342 DCHECK(value); 342 DCHECK(value);
343 m_data.append(std::move(value)); 343 m_data.append(std::move(value));
344 } 344 }
345 345
346 protocol::Value* ListValue::at(size_t index) 346 protocol::Value* ListValue::at(size_t index)
347 { 347 {
348 ASSERT_WITH_SECURITY_IMPLICATION(index < m_data.size()); 348 DCHECK_LT(index, m_data.size());
349 return m_data[index]; 349 return m_data[index];
350 } 350 }
351 351
352 } // namespace protocol 352 } // namespace protocol
353 } // namespace blink 353 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698