Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so
after  detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).

Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.

BUG=614409
Committed: https://crrev.com/c9cc06afc9329f475cf5efd244cc80f713728873
Cr-Commit-Position: refs/heads/master@{#401987}

[majidvp, 2016-05-24 17:04:19]

Description was changed from

==========
Mockabe tick clock for events

Adds necessary hooks to allow mocking underlying tick clock used in ui/events

BUG=
==========

to

==========
Assert ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Also adds necessary hooks to allow mocking underlying tick clock used in
ui/events.

BUG=614409
==========

[majidvp, 2016-06-17 02:45:13]

Description was changed from

==========
Assert ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Also adds necessary hooks to allow mocking underlying tick clock used in
ui/events.

BUG=614409
==========

to

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp clock correction logic an apply it on
all platforms. On X11 this is not exceptional so we detect deviation from  clock
and make corrections by falling back to base::TimeTicks.  For all other
platforms, this should not happen so we assert and fail if it does and thus it
is restricted to the DCHECK builds .

Other changes:

- add hooks to allow mocking underlying tick clock used in ui/events.
- expose ui/events:base_event a public dependency ui/events in gyp build. This
matches current GN build and it is necessary because we have moved
ui:EventTimeForNow from events to to base_events.


BUG=614409
==========

[majidvp, 2016-06-17 02:52:00]

Description was changed from

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp clock correction logic an apply it on
all platforms. On X11 this is not exceptional so we detect deviation from  clock
and make corrections by falling back to base::TimeTicks.  For all other
platforms, this should not happen so we assert and fail if it does and thus it
is restricted to the DCHECK builds .

Other changes:

- add hooks to allow mocking underlying tick clock used in ui/events.
- expose ui/events:base_event a public dependency ui/events in gyp build. This
matches current GN build and it is necessary because we have moved
ui:EventTimeForNow from events to to base_events.


BUG=614409
==========

to

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp clock correction logic an apply it on
all platforms. On X11 this is not exceptional so we detect deviation from  clock
and make corrections by falling back to base::TimeTicks.  For all other
platforms, this should not happen so we assert and fail if it does and thus it
is restricted to the DCHECK builds .

Other changes:

- add hooks to allow mocking underlying tick clock used in ui/events.
- expose ui/events:base_event a public dependency ui/events in gyp build. This
matches current GN build and it is necessary because we have moved
ui:EventTimeForNow from events to to base_events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.


BUG=614409
==========

[majidvp, 2016-06-21 21:12:13]

Description was changed from

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp clock correction logic an apply it on
all platforms. On X11 this is not exceptional so we detect deviation from  clock
and make corrections by falling back to base::TimeTicks.  For all other
platforms, this should not happen so we assert and fail if it does and thus it
is restricted to the DCHECK builds .

Other changes:

- add hooks to allow mocking underlying tick clock used in ui/events.
- expose ui/events:base_event a public dependency ui/events in gyp build. This
matches current GN build and it is necessary because we have moved
ui:EventTimeForNow from events to to base_events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.


BUG=614409
==========

to

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so 
after  detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).

Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.


BUG=614409
==========

[majidvp, 2016-06-22 11:54:50]

majidvp@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-06-23 16:38:37]

ui lgtm. But I do not understand the mac bits in content/ Can you get a review
from one of the mac owners for those files?

https://codereview.chromium.org/2007083002/diff/180001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
(right):

https://codereview.chromium.org/2007083002/diff/180001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_mac_unittest.mm:247:
mock_clock->Advance(base::TimeDelta::FromMilliseconds(100));
What is the purpose of this?

https://codereview.chromium.org/2007083002/diff/180001/ui/events/base_event_u...
File ui/events/base_event_utils.h (right):

https://codereview.chromium.org/2007083002/diff/180001/ui/events/base_event_u...
ui/events/base_event_utils.h:9: #include <memory>
sort

https://codereview.chromium.org/2007083002/diff/180001/ui/events/test/event_g...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/2007083002/diff/180001/ui/events/test/event_g...
ui/events/test/event_generator.cc:610: // mockable so we no longer need this.
So SetTickClick() and Now() from EventGenerator can go?

[majidvp, 2016-06-24 19:40:56]

https://codereview.chromium.org/2007083002/diff/180001/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
(right):

https://codereview.chromium.org/2007083002/diff/180001/content/browser/render...
content/browser/renderer_host/render_widget_host_view_mac_unittest.mm:247:
mock_clock->Advance(base::TimeDelta::FromMilliseconds(100));
On 2016/06/23 16:38:37, sadrul wrote:
> What is the purpose of this?

If I recall correctly, there was an assert somewhere for the clock not being
zero! So I have to use a non-zero 
value which I choose 100ms.

https://codereview.chromium.org/2007083002/diff/180001/ui/events/base_event_u...
File ui/events/base_event_utils.h (right):

https://codereview.chromium.org/2007083002/diff/180001/ui/events/base_event_u...
ui/events/base_event_utils.h:9: #include <memory>
On 2016/06/23 16:38:37, sadrul wrote:
> sort

Done.

https://codereview.chromium.org/2007083002/diff/180001/ui/events/test/event_g...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/2007083002/diff/180001/ui/events/test/event_g...
ui/events/test/event_generator.cc:610: // mockable so we no longer need this.
On 2016/06/23 16:38:37, sadrul wrote:
> So SetTickClick() and Now() from EventGenerator can go?

Yes. I think we can replace them with ui::SetEventTickClockForTesting and
ui::EventTimeForNow.
I will have a follow up patch that does that.

[majidvp, 2016-06-24 19:45:32]

majidvp@chromium.org changed reviewers:
+ ccameron@chromium.org

[majidvp, 2016-06-24 19:45:33]

+ ccameron@: Can you please review Mac bits in content and chrome/browser.

[ccameron, 2016-06-24 20:24:25]

Mac bits lgtm

[majidvp, 2016-06-24 21:07:02]

The CQ bit was checked by majidvp@chromium.org

[majidvp, 2016-06-24 21:07:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2007083002/#ps200001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-06-24 21:07:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 21:58:43]

Description was changed from

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so 
after  detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).

Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.


BUG=614409
==========

to

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so 
after  detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).

Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.


BUG=614409
==========

[commit-bot: I haz the power, 2016-06-24 21:58:44]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-24 22:00:53]

Description was changed from

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so 
after  detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).

Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.


BUG=614409
==========

to

==========
Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so
after  detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).

Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.

BUG=614409

Committed: https://crrev.com/c9cc06afc9329f475cf5efd244cc80f713728873
Cr-Commit-Position: refs/heads/master@{#401987}
==========

[commit-bot: I haz the power, 2016-06-24 22:00:54]

Patchset 11 (id:??) landed as
https://crrev.com/c9cc06afc9329f475cf5efd244cc80f713728873
Cr-Commit-Position: refs/heads/master@{#401987}