DescriptionValidate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now
Generalize existing X11 event timestamp's clock mismatch detection logic and use
it on all platforms. On X11 deviation from system clock is not exceptional so
after detection we correct by falling back to TimeTicks::Now(). On all other
platforms, this is an exception so we assert and fail (only on DCHECK builds).
Other changes:
- add hooks to allow mocking underlying tick clock used in ui/events.
- fix bug in textfield double click detection logic where small timestamp values
led to breakage.
BUG=614409
Committed: https://crrev.com/c9cc06afc9329f475cf5efd244cc80f713728873
Cr-Commit-Position: refs/heads/master@{#401987}
Patch Set 1 #Patch Set 2 : Add DCHECK #Patch Set 3 : rebase #Patch Set 4 : Rebase and use on all build on X11 #Patch Set 5 : Fix textfield bug #Patch Set 6 : Fix chromeos issue #Patch Set 7 : fail fast on non-x11 #Patch Set 8 : Remove evdev to a separate patch #Patch Set 9 : Fix macOs and chromeOS #Patch Set 10 : Fix macOS test #
Total comments: 6
Patch Set 11 : Address feedback #
Dependent Patchsets: Messages
Total messages: 18 (10 generated)
|