Remove unnecessary mocking of TickClock for events

Remove unnecessary mocking of TickClock for events

It is possible now to mock the clock used in ui/events so it is
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
Committed: https://crrev.com/0eee00fdfb2ac517e576624a3766904dd95bffbb
Cr-Commit-Position: refs/heads/master@{#403805}

[majidvp, 2016-06-28 20:20:17]

Description was changed from

==========
Remove unnecesasry TickClock mocking methods

Now it is possible to mock the clock used in ui/events so it is not necessary
to have these hooks.

BUG=
==========

to

==========
Remove unnecesasry TickClock mocking methods

It is possible now to mock the clock used in ui/events so it is 
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
==========

[majidvp, 2016-06-28 20:20:18]

majidvp@chromium.org changed reviewers:
+ sadrul@chromium.org

[majidvp, 2016-06-28 20:20:52]

Description was changed from

==========
Remove unnecesasry TickClock mocking methods

It is possible now to mock the clock used in ui/events so it is 
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
==========

to

==========
Remove unnecessary mocking of TickClock for events

It is possible now to mock the clock used in ui/events so it is 
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
==========

[majidvp, 2016-06-28 20:22:04]

The CQ bit was checked by majidvp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 20:23:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:00:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 22:00:22]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-06-30 14:30:11]

lgtm

https://codereview.chromium.org/2100453002/diff/40001/ui/events/test/event_ge...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/2100453002/diff/40001/ui/events/test/event_ge...
ui/events/test/event_generator.cc:552:
ui::SetEventTickClockForTesting(WrapUnique(new TestTickClock()));
Should you unset it from the dtor? (see
https://codereview.chromium.org/2094193002/diff/80001/ui/events/test/event_ge...)

[majidvp, 2016-07-05 01:52:59]

The CQ bit was checked by majidvp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 01:53:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[majidvp, 2016-07-05 01:59:47]

https://codereview.chromium.org/2100453002/diff/40001/ui/events/test/event_ge...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/2100453002/diff/40001/ui/events/test/event_ge...
ui/events/test/event_generator.cc:552:
ui::SetEventTickClockForTesting(WrapUnique(new TestTickClock()));
On 2016/06/30 14:30:11, sadrul wrote:
> Should you unset it from the dtor? (see
>
https://codereview.chromium.org/2094193002/diff/80001/ui/events/test/event_ge...)

Yes it should be. It is actually unset from dtor in the patch you linked
for event_generator.

But I realized that could create lifetime issues for TickClock in 
touch_exploration_controler_unittest [1]. I fixed that by correctly
mocking the tick clock in SetUp and clearing it in teardown which is
more appropriate for the test IMHO.

[1]
https://codereview.chromium.org/2100453002/diff/80001/ui/chromeos/touch_explo...

[majidvp, 2016-07-05 02:00:14]

majidvp@chromium.org changed reviewers:
+ reveman@chromium.org

[majidvp, 2016-07-05 02:00:15]

+reveman@: Please review components/exo

[commit-bot: I haz the power, 2016-07-05 02:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 02:35:13]

Dry run: This issue passed the CQ dry run.

[reveman, 2016-07-05 17:42:23]

components/exo lgtm

[majidvp, 2016-07-05 18:16:03]

The CQ bit was checked by majidvp@chromium.org

[majidvp, 2016-07-05 18:16:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2100453002/#ps80001
(title: "Fix touch_unittests")

[commit-bot: I haz the power, 2016-07-05 18:16:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 18:21:06]

Description was changed from

==========
Remove unnecessary mocking of TickClock for events

It is possible now to mock the clock used in ui/events so it is 
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
==========

to

==========
Remove unnecessary mocking of TickClock for events

It is possible now to mock the clock used in ui/events so it is 
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
==========

[commit-bot: I haz the power, 2016-07-05 18:21:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-05 18:21:13]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-05 18:23:25]

Description was changed from

==========
Remove unnecessary mocking of TickClock for events

It is possible now to mock the clock used in ui/events so it is 
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409
==========

to

==========
Remove unnecessary mocking of TickClock for events

It is possible now to mock the clock used in ui/events so it is
no longer necessary to have these individual mock tick clocks
for events.

BUG=614409

Committed: https://crrev.com/0eee00fdfb2ac517e576624a3766904dd95bffbb
Cr-Commit-Position: refs/heads/master@{#403805}
==========

[commit-bot: I haz the power, 2016-07-05 18:23:27]

Patchset 5 (id:??) landed as
https://crrev.com/0eee00fdfb2ac517e576624a3766904dd95bffbb
Cr-Commit-Position: refs/heads/master@{#403805}