ui/views/controls/textfield/textfield.cc - Issue 2007083002: Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2007083002: Validate that ui::Event::time_stamp comes from the same clock as TimeTicks::Now (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@453559-use-timeticks-ui-event

Patch Set: Address feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 85c318a03008ae83a4b8f43515478ff3866f0e4a..e1cc9d40294a54f88c6a5e8302f1dba178566694 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -1868,7 +1868,8 @@ void Textfield::UpdateContextMenu() {

void Textfield::TrackMouseClicks(const ui::MouseEvent& event) {

if (event.IsOnlyLeftMouseButton()) {

base::TimeDelta time_delta = event.time_stamp() - last_click_time_;

- if (time_delta.InMilliseconds() <= GetDoubleClickInterval() &&

+ if (!last_click_time_.is_null() &&

+ time_delta.InMilliseconds() <= GetDoubleClickInterval() &&

!ExceededDragThreshold(event.location() - last_click_location_)) {

// Upon clicking after a triple click, the count should go back to double

// click and alternate between double and triple. This assignment maps

« no previous file with comments | « ui/message_center/message_center.gyp ('k') | no next file » | no next file with comments »