Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2007003003: Check subtree paint invalidation when overflow clip status changes (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, krit, f(malita), jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Check subtree paint invalidation when overflow clip status changes Before https://crrev.com/392652 because we included descendant overflow into container overflow and the paint invalidation rect covered the changed part of descendants. Call setNeedsPaintInvalidationSubtree() to force checking of paint invalidation of descendants when overflow clip status changes. The other changes are needed because we need to move clearPaintInvalidationFlags() after newPaintInvalidationState.updateForChildren(). Several overriding invalidateTreeIfNeeded() methods in subclasses are removed because they have been the same as inherited ones after we changed the paint invalidation tree walk order. BUG=613475 TEST=paint/invalidation/overflow-hidden-to-visible.html TEST=paint/invalidation/overflow-visible-to-hidden.html Review-Url: https://codereview.chromium.org/2000763003 Cr-Commit-Position: refs/heads/master@{#395491} Committed: https://chromium.googlesource.com/chromium/src/+/3104da0648b2a0fac4ca5463180949a98f7c3414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -44 lines) Patch
M third_party/WebKit/LayoutTests/fast/repaint/erase-overflow-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-to-visible.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-to-visible-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/overflow-visible-to-hidden.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/overflow-visible-to-hidden-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 4 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 chunk +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Xianzhu
4 years, 7 months ago (2016-05-25 00:04:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3104da0648b2a0fac4ca5463180949a98f7c3414.

Powered by Google App Engine
This is Rietveld 408576698