Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

Issue 2007003003: Check subtree paint invalidation when overflow clip status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz> 2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
3 * Copyright (C) 2006 Apple Inc. All rights reserved. 3 * Copyright (C) 2006 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 { 138 {
139 SVGResourcesCache::clientWillBeRemovedFromTree(child); 139 SVGResourcesCache::clientWillBeRemovedFromTree(child);
140 140
141 if (LayoutSVGText* textLayoutObject = LayoutSVGText::locateLayoutSVGTextAnce stor(this)) 141 if (LayoutSVGText* textLayoutObject = LayoutSVGText::locateLayoutSVGTextAnce stor(this))
142 textLayoutObject->subtreeChildWillBeRemoved(); 142 textLayoutObject->subtreeChildWillBeRemoved();
143 LayoutInline::removeChild(child); 143 LayoutInline::removeChild(child);
144 } 144 }
145 145
146 void LayoutSVGInline::invalidateTreeIfNeeded(const PaintInvalidationState& paint InvalidationState) 146 void LayoutSVGInline::invalidateTreeIfNeeded(const PaintInvalidationState& paint InvalidationState)
147 { 147 {
148 ASSERT(!needsLayout()); 148 // TODO(wangxianzhu): Verify if the inherited LayoutBoxModelObject::invalida teTreeIfNeeded()
149 149 // is applicable here. If yes, remove this overriding method.
150 if (!shouldCheckForPaintInvalidation(paintInvalidationState)) 150 LayoutObject::invalidateTreeIfNeeded(paintInvalidationState);
151 return;
152
153 PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *th is);
154 PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidatio nState);
155 clearPaintInvalidationFlags(newPaintInvalidationState);
156
157 newPaintInvalidationState.updateForChildren(reason);
158 invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);
159 } 151 }
160 152
161 } // namespace blink 153 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698