Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Issue 2007003003: Check subtree paint invalidation when overflow clip status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
index 584e9dce0b2b4c5123b969277ddd8e60ec3880d1..477024df8d54a8f15ac1581c851c023f1566d995 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
@@ -396,17 +396,9 @@ void LayoutSVGText::removeChild(LayoutObject* child)
void LayoutSVGText::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)
{
- ASSERT(!needsLayout());
-
- if (!shouldCheckForPaintInvalidation(paintInvalidationState))
- return;
-
- PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *this);
- PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidationState);
- clearPaintInvalidationFlags(newPaintInvalidationState);
-
- newPaintInvalidationState.updateForChildren(reason);
- invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);
+ // TODO(wangxianzhu): Verify if the inherited LayoutBoxModelObject::invalidateTreeIfNeeded()
+ // is applicable here. If yes, remove this overriding method.
+ LayoutObject::invalidateTreeIfNeeded(paintInvalidationState);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698