Reduce boilerplace for common pattern to return MaybeHandle.

Reduce boilerplace for common pattern to return MaybeHandle.

R=franzih@chromium.org

Committed: https://crrev.com/47af330df7ad9f0fe48de51b53b9c49f46b50f88
Cr-Commit-Position: refs/heads/master@{#36470}

[Franzi, 2016-05-23 17:40:56]

lgtm

LGTM.

[Yang, 2016-05-23 18:16:07]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-05-23 18:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006673002/1

[commit-bot: I haz the power, 2016-05-23 18:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 18:19:42]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15804)

[Yang, 2016-05-23 18:28:42]

yangguo@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Yang, 2016-05-23 18:28:43]

Jakob, could you give src/ic an OWNERs ok?

[Jakob Kummerow, 2016-05-24 09:16:22]

src/ic/ LGTM.

https://codereview.chromium.org/2006673002/diff/20001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2006673002/diff/20001/src/isolate.h#newcode132
src/isolate.h:132: return isolate->heap()->exception();        \
It seems inconsistent that the DCHECK line puts parentheses around (isolate) but
this line doesn't. If we want to be robust against funky expressions being used
as inputs we should be so everywhere.

[Yang, 2016-05-24 11:07:21]

https://codereview.chromium.org/2006673002/diff/20001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2006673002/diff/20001/src/isolate.h#newcode132
src/isolate.h:132: return isolate->heap()->exception();        \
On 2016/05/24 09:16:21, Jakob wrote:
> It seems inconsistent that the DCHECK line puts parentheses around (isolate)
but
> this line doesn't. If we want to be robust against funky expressions being
used
> as inputs we should be so everywhere.

you are right. We actually have this problem below as well. Will fix.

[Yang, 2016-05-24 11:07:56]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-24 11:07:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
franzih@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2006673002/#ps40001
(title: "rebase and fix")

[commit-bot: I haz the power, 2016-05-24 11:07:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006673002/40001

[commit-bot: I haz the power, 2016-05-24 11:45:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 11:46:40]

Description was changed from

==========
Reduce boilerplace for common pattern to return MaybeHandle.

R=franzih@chromium.org
==========

to

==========
Reduce boilerplace for common pattern to return MaybeHandle.

R=franzih@chromium.org

Committed: https://crrev.com/47af330df7ad9f0fe48de51b53b9c49f46b50f88
Cr-Commit-Position: refs/heads/master@{#36470}
==========

[commit-bot: I haz the power, 2016-05-24 11:46:41]

Patchset 3 (id:??) landed as
https://crrev.com/47af330df7ad9f0fe48de51b53b9c49f46b50f88
Cr-Commit-Position: refs/heads/master@{#36470}