Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/runtime/runtime-json.cc

Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase and fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-internal.cc ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/char-predicates-inl.h" 8 #include "src/char-predicates-inl.h"
9 #include "src/isolate-inl.h" 9 #include "src/isolate-inl.h"
10 #include "src/json-parser.h" 10 #include "src/json-parser.h"
11 #include "src/json-stringifier.h" 11 #include "src/json-stringifier.h"
12 #include "src/objects-inl.h" 12 #include "src/objects-inl.h"
13 13
14 namespace v8 { 14 namespace v8 {
15 namespace internal { 15 namespace internal {
16 16
17 RUNTIME_FUNCTION(Runtime_QuoteJSONString) { 17 RUNTIME_FUNCTION(Runtime_QuoteJSONString) {
18 HandleScope scope(isolate); 18 HandleScope scope(isolate);
19 CONVERT_ARG_HANDLE_CHECKED(String, string, 0); 19 CONVERT_ARG_HANDLE_CHECKED(String, string, 0);
20 DCHECK(args.length() == 1); 20 DCHECK(args.length() == 1);
21 Handle<Object> result; 21 RETURN_RESULT_OR_FAILURE(
22 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 22 isolate, BasicJsonStringifier::StringifyString(isolate, string));
23 isolate, result, BasicJsonStringifier::StringifyString(isolate, string));
24 return *result;
25 } 23 }
26 24
27 RUNTIME_FUNCTION(Runtime_BasicJSONStringify) { 25 RUNTIME_FUNCTION(Runtime_BasicJSONStringify) {
28 HandleScope scope(isolate); 26 HandleScope scope(isolate);
29 DCHECK(args.length() == 2); 27 DCHECK(args.length() == 2);
30 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0); 28 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
31 CONVERT_ARG_HANDLE_CHECKED(Object, gap, 1); 29 CONVERT_ARG_HANDLE_CHECKED(Object, gap, 1);
32 Handle<Object> result; 30 RETURN_RESULT_OR_FAILURE(
33 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 31 isolate, BasicJsonStringifier(isolate).Stringify(object, gap));
34 isolate, result, BasicJsonStringifier(isolate).Stringify(object, gap));
35 return *result;
36 } 32 }
37 33
38 RUNTIME_FUNCTION(Runtime_ParseJson) { 34 RUNTIME_FUNCTION(Runtime_ParseJson) {
39 HandleScope scope(isolate); 35 HandleScope scope(isolate);
40 DCHECK_EQ(1, args.length()); 36 DCHECK_EQ(1, args.length());
41 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0); 37 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
42 Handle<String> source; 38 Handle<String> source;
43 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, source, 39 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, source,
44 Object::ToString(isolate, object)); 40 Object::ToString(isolate, object));
45 source = String::Flatten(source); 41 source = String::Flatten(source);
46 // Optimized fast case where we only have Latin1 characters. 42 // Optimized fast case where we only have Latin1 characters.
47 Handle<Object> result; 43 RETURN_RESULT_OR_FAILURE(isolate, source->IsSeqOneByteString()
48 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, 44 ? JsonParser<true>::Parse(source)
49 source->IsSeqOneByteString() 45 : JsonParser<false>::Parse(source));
50 ? JsonParser<true>::Parse(source)
51 : JsonParser<false>::Parse(source));
52 return *result;
53 } 46 }
54 47
55 } // namespace internal 48 } // namespace internal
56 } // namespace v8 49 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-internal.cc ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698