Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/runtime/runtime-array.cc

Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase and fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.h ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/conversions-inl.h" 9 #include "src/conversions-inl.h"
10 #include "src/elements.h" 10 #include "src/elements.h"
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 // returns false. 497 // returns false.
498 UNIMPLEMENTED(); 498 UNIMPLEMENTED();
499 return nullptr; 499 return nullptr;
500 } 500 }
501 501
502 502
503 RUNTIME_FUNCTION(Runtime_ArraySpeciesConstructor) { 503 RUNTIME_FUNCTION(Runtime_ArraySpeciesConstructor) {
504 HandleScope scope(isolate); 504 HandleScope scope(isolate);
505 DCHECK(args.length() == 1); 505 DCHECK(args.length() == 1);
506 CONVERT_ARG_HANDLE_CHECKED(Object, original_array, 0); 506 CONVERT_ARG_HANDLE_CHECKED(Object, original_array, 0);
507 Handle<Object> constructor; 507 RETURN_RESULT_OR_FAILURE(
508 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 508 isolate, Object::ArraySpeciesConstructor(isolate, original_array));
509 isolate, constructor,
510 Object::ArraySpeciesConstructor(isolate, original_array));
511 return *constructor;
512 } 509 }
513 510
514 } // namespace internal 511 } // namespace internal
515 } // namespace v8 512 } // namespace v8
OLDNEW
« no previous file with comments | « src/isolate.h ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698