src/runtime/runtime-array.cc - Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 2006673002: Reduce boilerplace for common pattern to return MaybeHandle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase and fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 05c7d92283b1106f074265cafe5361e8bee8c5f8..06e5f312304fc9e70a5287ba570431d006cc4d0c 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -504,11 +504,8 @@ RUNTIME_FUNCTION(Runtime_ArraySpeciesConstructor) {

HandleScope scope(isolate);

DCHECK(args.length() == 1);

CONVERT_ARG_HANDLE_CHECKED(Object, original_array, 0);

- Handle<Object> constructor;

- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

- isolate, constructor,

- Object::ArraySpeciesConstructor(isolate, original_array));

- return *constructor;

+ RETURN_RESULT_OR_FAILURE(

+ isolate, Object::ArraySpeciesConstructor(isolate, original_array));

}

} // namespace internal

« no previous file with comments | « src/isolate.h ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »