Avoid calling lower() on inline styles in parseKeywordValue.

Avoid calling lower() on inline styles in parseKeywordValue.

We were doing string.lower() on every inline style that was assigned
to a non-keyword property to compare the value to "inherit" and
"initial". This is wasteful and shows up in profiles, instead lets use
equalIgnoringASCIICase.

To do this we need to expand the overload set for
equalIgnoringASCIICase to include one that takes a const char* so that
we don't allocate a temporary String instance when passing a literal.
We also inline the call to strlen so that the compiler can figure out
the length for us and avoid calling strlen at runtime.

This reduces the script execution time of Animometer > Leaves by 1% on
my Macbook Pro.

BUG=606211
Committed: https://crrev.com/d56e7dd93c7a25a390ebda860dcd17a17533d5f8
Cr-Commit-Position: refs/heads/master@{#395809}

[esprehn, 2016-05-24 22:44:27]

https://codereview.chromium.org/2006413002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/StringImpl.cpp (left):

https://codereview.chromium.org/2006413002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/StringImpl.cpp:2300: CHECK_LE(length,
numeric_limits<unsigned>::max());
This isn't needed, we're not going to allocate a string with |b|, and the
comparison between an unsigned and a size_t is defined, if for some reason |b|
was actually bigger than UINT_MAX it would necessarily fail the comparison to
the length() below which unsigned.

[esprehn, 2016-05-24 22:45:26]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 22:45:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006413002/1

[esprehn, 2016-05-24 22:47:59]

esprehn@chromium.org changed reviewers:
+ meade@chromium.org, timloh@chromium.org

[esprehn, 2016-05-24 22:48:20]

Description was changed from

==========
Avoid calling lower() on inline styles in parseKeywordValue.

We were doing string.lower() on every inline style that was assigned
to a non-keyword property to compare the value to "inherit" and
"initial". This is wasteful and shows up in profiles, instead lets use
equalIgnoringASCIICase.

To do this we need to expand the overload set for
equalIgnoringASCIICase to include one that takes a const char* so that
we don't allocate a temporary String instance when passing a literal.
We also inline the call to strlen so that the compiler can figure out
the length for us and avoid calling strlen at runtime.

BUG=606211
==========

to

==========
Avoid calling lower() on inline styles in parseKeywordValue.

We were doing string.lower() on every inline style that was assigned
to a non-keyword property to compare the value to "inherit" and
"initial". This is wasteful and shows up in profiles, instead lets use
equalIgnoringASCIICase.

To do this we need to expand the overload set for
equalIgnoringASCIICase to include one that takes a const char* so that
we don't allocate a temporary String instance when passing a literal.
We also inline the call to strlen so that the compiler can figure out
the length for us and avoid calling strlen at runtime.

This reduces the script execution time of Animometer > Leaves by 1% on
my Macbook Pro.

BUG=606211
==========

[commit-bot: I haz the power, 2016-05-25 01:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 01:52:40]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-25 01:52:53]

Dry run: None

[esprehn, 2016-05-25 03:57:50]

esprehn@chromium.org changed reviewers:
+ yutak@chromium.org

[esprehn, 2016-05-25 03:57:51]

Yukta@ for wtf

[esprehn, 2016-05-25 03:58:19]

On 2016/05/25 at 03:57:51, esprehn wrote:
> Yukta@ for wtf

yutak*

[Yuta Kitamura, 2016-05-25 04:10:09]

wtf LGTM

[dstockwell, 2016-05-25 05:36:46]

dstockwell@chromium.org changed reviewers:
+ dstockwell@chromium.org

[dstockwell, 2016-05-25 05:36:47]

lgtm

[esprehn, 2016-05-25 05:41:14]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-05-25 05:41:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006413002/1

[commit-bot: I haz the power, 2016-05-25 05:44:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 05:47:34]

Description was changed from

==========
Avoid calling lower() on inline styles in parseKeywordValue.

We were doing string.lower() on every inline style that was assigned
to a non-keyword property to compare the value to "inherit" and
"initial". This is wasteful and shows up in profiles, instead lets use
equalIgnoringASCIICase.

To do this we need to expand the overload set for
equalIgnoringASCIICase to include one that takes a const char* so that
we don't allocate a temporary String instance when passing a literal.
We also inline the call to strlen so that the compiler can figure out
the length for us and avoid calling strlen at runtime.

This reduces the script execution time of Animometer > Leaves by 1% on
my Macbook Pro.

BUG=606211
==========

to

==========
Avoid calling lower() on inline styles in parseKeywordValue.

We were doing string.lower() on every inline style that was assigned
to a non-keyword property to compare the value to "inherit" and
"initial". This is wasteful and shows up in profiles, instead lets use
equalIgnoringASCIICase.

To do this we need to expand the overload set for
equalIgnoringASCIICase to include one that takes a const char* so that
we don't allocate a temporary String instance when passing a literal.
We also inline the call to strlen so that the compiler can figure out
the length for us and avoid calling strlen at runtime.

This reduces the script execution time of Animometer > Leaves by 1% on
my Macbook Pro.

BUG=606211

Committed: https://crrev.com/d56e7dd93c7a25a390ebda860dcd17a17533d5f8
Cr-Commit-Position: refs/heads/master@{#395809}
==========

[commit-bot: I haz the power, 2016-05-25 05:47:35]

Patchset 1 (id:??) landed as
https://crrev.com/d56e7dd93c7a25a390ebda860dcd17a17533d5f8
Cr-Commit-Position: refs/heads/master@{#395809}