Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

Issue 2006413002: Avoid calling lower() on inline styles in parseKeywordValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/parser/CSSParserFastPaths.h" 5 #include "core/css/parser/CSSParserFastPaths.h"
6 6
7 #include "core/css/CSSPrimitiveValue.h" 7 #include "core/css/CSSPrimitiveValue.h"
8 #include "core/css/CSSValueList.h" 8 #include "core/css/CSSValueList.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 TEST(CSSParserFastPathsTest, ParseKeyword)
14 {
15 CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "lef t", HTMLStandardMode);
16 ASSERT_NE(nullptr, value);
17 EXPECT_TRUE(value->isPrimitiveValue());
18 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
19 EXPECT_TRUE(primitiveValue->isValueID());
20 EXPECT_EQ(CSSValueLeft, primitiveValue->getValueID());
21 value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "foo", HTMLSta ndardMode);
22 ASSERT_EQ(nullptr, value);
23 }
24 TEST(CSSParserFastPathsTest, ParseInitialAndInheritKeyword)
25 {
26 CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginTop, "inherit", HTMLStandardMode);
27 ASSERT_NE(nullptr, value);
28 EXPECT_TRUE(value->isInheritedValue());
29 value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginRight, "InHeriT ", HTMLStandardMode);
30 ASSERT_NE(nullptr, value);
31 EXPECT_TRUE(value->isInheritedValue());
32 value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginBottom, "initia l", HTMLStandardMode);
33 ASSERT_NE(nullptr, value);
34 EXPECT_TRUE(value->isInitialValue());
35 value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginLeft, "IniTiaL" , HTMLStandardMode);
36 ASSERT_NE(nullptr, value);
37 EXPECT_TRUE(value->isInitialValue());
38 // Fast path doesn't handle short hands.
39 value = CSSParserFastPaths::maybeParseValue(CSSPropertyMargin, "initial", HT MLStandardMode);
40 ASSERT_EQ(nullptr, value);
41 }
42
13 TEST(CSSParserFastPathsTest, ParseTransform) 43 TEST(CSSParserFastPathsTest, ParseTransform)
14 { 44 {
15 CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate(5.5px, 5px)", HTMLStandardMode); 45 CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate(5.5px, 5px)", HTMLStandardMode);
16 ASSERT_NE(nullptr, value); 46 ASSERT_NE(nullptr, value);
17 ASSERT_TRUE(value->isValueList()); 47 ASSERT_TRUE(value->isValueList());
18 ASSERT_EQ("translate(5.5px, 5px)", value->cssText()); 48 ASSERT_EQ("translate(5.5px, 5px)", value->cssText());
19 49
20 value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate 3d(5px, 5px, 10.1px)", HTMLStandardMode); 50 value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate 3d(5px, 5px, 10.1px)", HTMLStandardMode);
21 ASSERT_NE(nullptr, value); 51 ASSERT_NE(nullptr, value);
22 ASSERT_TRUE(value->isValueList()); 52 ASSERT_TRUE(value->isValueList());
(...skipping 23 matching lines...) Expand all
46 76
47 TEST(CSSParserFastPathsTest, ParseTransformNotFastPath) 77 TEST(CSSParserFastPathsTest, ParseTransformNotFastPath)
48 { 78 {
49 CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "rotateX(1deg)", HTMLStandardMode); 79 CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "rotateX(1deg)", HTMLStandardMode);
50 ASSERT_EQ(nullptr, value); 80 ASSERT_EQ(nullptr, value);
51 value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate Z(1px) rotateX(1deg)", HTMLStandardMode); 81 value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate Z(1px) rotateX(1deg)", HTMLStandardMode);
52 ASSERT_EQ(nullptr, value); 82 ASSERT_EQ(nullptr, value);
53 } 83 }
54 84
55 } // namespace blink 85 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698