Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.cpp

Issue 2006413002: Avoid calling lower() on inline styles in parseKeywordValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringImpl.h ('k') | third_party/WebKit/Source/wtf/text/WTFString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/StringImpl.cpp
diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.cpp b/third_party/WebKit/Source/wtf/text/StringImpl.cpp
index a37127b497efe30b7cb0df628c3103f040d2077e..1fcfd6b45a2a792439a483cf9644d216b410a1b6 100644
--- a/third_party/WebKit/Source/wtf/text/StringImpl.cpp
+++ b/third_party/WebKit/Source/wtf/text/StringImpl.cpp
@@ -2292,12 +2292,10 @@ bool equalIgnoringASCIICase(const StringImpl* a, const StringImpl* b)
return equalIgnoringASCIICase(a->characters16(), b->characters16(), length);
}
-bool equalIgnoringASCIICase(const StringImpl* a, const LChar* b)
+bool equalIgnoringASCIICase(const StringImpl* a, const LChar* b, unsigned length)
{
if (!a || !b)
return !a == !b;
- size_t length = strlen(reinterpret_cast<const char*>(b));
- CHECK_LE(length, numeric_limits<unsigned>::max());
esprehn 2016/05/24 22:44:26 This isn't needed, we're not going to allocate a s
if (length != a->length())
return false;
return equalSubstringIgnoringASCIICase(a, 0, b, length);
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringImpl.h ('k') | third_party/WebKit/Source/wtf/text/WTFString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698