Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp

Issue 2006413002: Avoid calling lower() on inline styles in parseKeywordValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
index 5e30abe85209123d176077892cedb16b70eab677..e603bd9e2e82b3ad93482446564316c323835c0a 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp
@@ -10,6 +10,36 @@
namespace blink {
+TEST(CSSParserFastPathsTest, ParseKeyword)
+{
+ CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "left", HTMLStandardMode);
+ ASSERT_NE(nullptr, value);
+ EXPECT_TRUE(value->isPrimitiveValue());
+ CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
+ EXPECT_TRUE(primitiveValue->isValueID());
+ EXPECT_EQ(CSSValueLeft, primitiveValue->getValueID());
+ value = CSSParserFastPaths::maybeParseValue(CSSPropertyFloat, "foo", HTMLStandardMode);
+ ASSERT_EQ(nullptr, value);
+}
+TEST(CSSParserFastPathsTest, ParseInitialAndInheritKeyword)
+{
+ CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginTop, "inherit", HTMLStandardMode);
+ ASSERT_NE(nullptr, value);
+ EXPECT_TRUE(value->isInheritedValue());
+ value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginRight, "InHeriT", HTMLStandardMode);
+ ASSERT_NE(nullptr, value);
+ EXPECT_TRUE(value->isInheritedValue());
+ value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginBottom, "initial", HTMLStandardMode);
+ ASSERT_NE(nullptr, value);
+ EXPECT_TRUE(value->isInitialValue());
+ value = CSSParserFastPaths::maybeParseValue(CSSPropertyMarginLeft, "IniTiaL", HTMLStandardMode);
+ ASSERT_NE(nullptr, value);
+ EXPECT_TRUE(value->isInitialValue());
+ // Fast path doesn't handle short hands.
+ value = CSSParserFastPaths::maybeParseValue(CSSPropertyMargin, "initial", HTMLStandardMode);
+ ASSERT_EQ(nullptr, value);
+}
+
TEST(CSSParserFastPathsTest, ParseTransform)
{
CSSValue* value = CSSParserFastPaths::maybeParseValue(CSSPropertyTransform, "translate(5.5px, 5px)", HTMLStandardMode);

Powered by Google App Engine
This is Rietveld 408576698