Migrate websockets from url+lineNumber to SourceLocation.

Migrate websockets from url+lineNumber to SourceLocation.

BUG=613882
Committed: https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0
Cr-Commit-Position: refs/heads/master@{#395896}

[dgozman, 2016-05-23 23:29:20]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org, yhirano@chromium.org

[dgozman, 2016-05-23 23:29:21]

Could you please take a look?
@pfeldman at SourceLocation.
@yhirano at websockets.

[yhirano, 2016-05-24 11:30:18]

modules/websockets lgtm

https://codereview.chromium.org/2004243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2004243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:155: if
(!capturedLocation->isEmpty()) {
Can you leave some comments saying we ignore the passed location intentionally
in this case?

[dgozman, 2016-05-24 22:12:50]

https://codereview.chromium.org/2004243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2004243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:155: if
(!capturedLocation->isEmpty()) {
On 2016/05/24 11:30:18, yhirano wrote:
> Can you leave some comments saying we ignore the passed location intentionally
> in this case?

Done.

[dgozman, 2016-05-24 22:12:58]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 22:13:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004243002/40001

[pfeldman, 2016-05-24 23:03:49]

lgtm

[commit-bot: I haz the power, 2016-05-24 23:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 23:58:00]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-24 23:58:12]

Dry run: None

[dgozman, 2016-05-25 03:07:06]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-25 03:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
yhirano@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2004243002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-05-25 03:07:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004243002/60001

[commit-bot: I haz the power, 2016-05-25 05:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 05:36:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-05-25 14:23:39]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-05-25 14:23:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004243002/60001

[commit-bot: I haz the power, 2016-05-25 16:00:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 16:01:38]

Description was changed from

==========
Migrate websockets from url+lineNumber to SourceLocation.

BUG=613882
==========

to

==========
Migrate websockets from url+lineNumber to SourceLocation.

BUG=613882

Committed: https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0
Cr-Commit-Position: refs/heads/master@{#395896}
==========

[commit-bot: I haz the power, 2016-05-25 16:01:40]

Patchset 4 (id:??) landed as
https://crrev.com/49dc50ea2e6a95b9f5a84ab91dc7995e84f531c0
Cr-Commit-Position: refs/heads/master@{#395896}