Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/WebKit/Source/modules/websockets/WebSocketChannel.h

Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-source-location-1
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
diff --git a/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h b/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
index 4f2b70b088b03a858b928eabf91ee49683748196..51bf3be0b97a16a9a75caee4bc363295ef8c4afb 100644
--- a/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
+++ b/third_party/WebKit/Source/modules/websockets/WebSocketChannel.h
@@ -31,6 +31,7 @@
#ifndef WebSocketChannel_h
#define WebSocketChannel_h
+#include "bindings/core/v8/SourceLocation.h"
#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
#include "platform/v8_inspector/public/ConsoleTypes.h"
@@ -84,16 +85,13 @@ public:
// Log the reason text and close the connection. Will call didClose().
// The MessageLevel parameter will be used for the level of the message
- // shown at the devtool console.
- // sourceURL and lineNumber parameters may be shown with the reason text
- // at the devtool console.
- // Even if sourceURL and lineNumber are specified, they may be ignored
- // and the "current" url and the line number in the sense of
- // JavaScript execution may be shown if this method is called in
- // a JS execution context.
- // You can specify String() and 0 for sourceURL and lineNumber
- // respectively, if you can't / needn't provide the information.
- virtual void fail(const String& reason, MessageLevel, const String& sourceURL, unsigned lineNumber) = 0;
+ // shown at the devtools console.
+ // SourceLocation parameter may be shown with the reason text
+ // at the devtools console. Even if location is specified, it may be ignored
+ // and the "current" location in the sense of JavaScript execution
+ // may be shown if this method is called in a JS execution context.
+ // You can pass null location if unknown.
+ virtual void fail(const String& reason, MessageLevel, PassOwnPtr<SourceLocation>) = 0;
// Do not call any methods after calling this method.
virtual void disconnect() = 0; // Will suppress didClose().

Powered by Google App Engine
This is Rietveld 408576698