third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp - Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp

Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-source-location-1

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp ('k') | third_party/WebKit/Source/modules/websockets/WebSocketChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp

index bc5d27324ab5065a62963721c7cbd09164f8656f..14df233ac47323d7cf12a2f971bc3d3121d5c549 100644

--- a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp

@@ -92,7 +92,7 @@ public:

: m_pageHolder(DummyPageHolder::create())

, m_channelClient(MockWebSocketChannelClient::create())

, m_handle(MockWebSocketHandle::create())

- , m_channel(DocumentWebSocketChannel::create(&m_pageHolder->document(), m_channelClient.get(), String(), 0, handle()))

+ , m_channel(DocumentWebSocketChannel::create(&m_pageHolder->document(), m_channelClient.get(), SourceLocation::capture(), handle()))

, m_sumOfConsumedBufferedAmount(0)

{

ON_CALL(*channelClient(), didConsumeBufferedAmount(_)).WillByDefault(Invoke(this, &DocumentWebSocketChannelTest::didConsumeBufferedAmount));

@@ -680,7 +680,7 @@ TEST_F(DocumentWebSocketChannelTest, failFromWebSocket)

EXPECT_CALL(*channelClient(), didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, WebSocketChannel::CloseEventCodeAbnormalClosure, String()));

}

- channel()->fail("fail message from WebSocket", ErrorMessageLevel, "sourceURL", 1234);

+ channel()->fail("fail message from WebSocket", ErrorMessageLevel, nullptr);

}

} // namespace