Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-source-location-1
Patch Set: rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SourceLocation_h 5 #ifndef SourceLocation_h
6 #define SourceLocation_h 6 #define SourceLocation_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "platform/v8_inspector/public/V8StackTrace.h" 9 #include "platform/v8_inspector/public/V8StackTrace.h"
10 #include "wtf/Forward.h" 10 #include "wtf/Forward.h"
(...skipping 10 matching lines...) Expand all
21 public: 21 public:
22 // Zero lineNumber and columnNumber mean unknown. Captures current stack tra ce. 22 // Zero lineNumber and columnNumber mean unknown. Captures current stack tra ce.
23 static PassOwnPtr<SourceLocation> capture(const String& url, unsigned lineNu mber, unsigned columnNumber); 23 static PassOwnPtr<SourceLocation> capture(const String& url, unsigned lineNu mber, unsigned columnNumber);
24 24
25 // Shortcut when location is unknown. Tries to capture call stack or parsing location if available. 25 // Shortcut when location is unknown. Tries to capture call stack or parsing location if available.
26 static PassOwnPtr<SourceLocation> capture(ExecutionContext* = nullptr); 26 static PassOwnPtr<SourceLocation> capture(ExecutionContext* = nullptr);
27 27
28 static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNum ber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId = 0); 28 static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNum ber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId = 0);
29 ~SourceLocation(); 29 ~SourceLocation();
30 30
31 bool isEmpty() const { return m_url.isNull(); }
31 String url() const { return m_url; } 32 String url() const { return m_url; }
32 unsigned lineNumber() const { return m_lineNumber; } 33 unsigned lineNumber() const { return m_lineNumber; }
33 unsigned columnNumber() const { return m_columnNumber; } 34 unsigned columnNumber() const { return m_columnNumber; }
34 std::unique_ptr<V8StackTrace> takeStackTrace() { return std::move(m_stackTra ce); } 35 std::unique_ptr<V8StackTrace> takeStackTrace() { return std::move(m_stackTra ce); }
35 int scriptId() const { return m_scriptId; } 36 int scriptId() const { return m_scriptId; }
36 void toTracedValue(TracedValue*, const char* name) const; 37 void toTracedValue(TracedValue*, const char* name) const;
38 PassOwnPtr<SourceLocation> clone() const;
37 39
38 private: 40 private:
39 SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber , std::unique_ptr<V8StackTrace>, int scriptId); 41 SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber , std::unique_ptr<V8StackTrace>, int scriptId);
40 42
41 String m_url; 43 String m_url;
42 unsigned m_lineNumber; 44 unsigned m_lineNumber;
43 unsigned m_columnNumber; 45 unsigned m_columnNumber;
44 std::unique_ptr<V8StackTrace> m_stackTrace; 46 std::unique_ptr<V8StackTrace> m_stackTrace;
45 int m_scriptId; 47 int m_scriptId;
46 }; 48 };
47 49
48 } // namespace blink 50 } // namespace blink
49 51
50 #endif // SourceLocation_h 52 #endif // SourceLocation_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698