[GN] Use build/config/locales.gni to simplify grit invocations.

[GN] Use build/config/locales.gni to simplify grit invocations.

Uses the variables defined in build/config/locales.gni to simplify
the grit invocations and remove the conditional to deal with the
different names for the "es-419" and "pt-BR" locales on iOS.

BUG=525492
Committed: https://crrev.com/de51485fd1db9d4a22ce90764f767ad80e823acf
Cr-Commit-Position: refs/heads/master@{#395127}

[sdefresne, 2016-05-20 11:03:03]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, estade@chromium.org

[sdefresne, 2016-05-20 11:03:04]

dpranke: Please take a look.
estade: please review the following as OWNERS
  - third_party/libaddressinput

If this LGTY both, can the last of you send this CL to the CQ?

[sdefresne, 2016-05-20 11:03:34]

Note that I only ported the BUILD.gn that use conditional for iOS, but this
should be usable for every platforms I think.

[Evan Stade, 2016-05-20 13:51:50]

cool, lgtm but the bots are red so we might not be able to cq for you

[Dirk Pranke, 2016-05-20 16:36:18]

lgtm if you fix the issue below and make check happy. If I have time later today
I'll see if I can take a stab at it.

https://codereview.chromium.org/2003433003/diff/1/components/strings/BUILD.gn
File components/strings/BUILD.gn (left):

https://codereview.chromium.org/2003433003/diff/1/components/strings/BUILD.gn...
components/strings/BUILD.gn:87: "components_strings_fake-bidi.pak",
_fake-bidi.pak isn't in the list of locales, so you're getting a bunch of `gn
check` errors from the targets that need it.

[sdefresne, 2016-05-20 16:46:15]

Please take another look.

https://codereview.chromium.org/2003433003/diff/1/components/strings/BUILD.gn
File components/strings/BUILD.gn (left):

https://codereview.chromium.org/2003433003/diff/1/components/strings/BUILD.gn...
components/strings/BUILD.gn:87: "components_strings_fake-bidi.pak",
On 2016/05/20 16:36:18, Dirk Pranke wrote:
> _fake-bidi.pak isn't in the list of locales, so you're getting a bunch of `gn
> check` errors from the targets that need it.

Ack. I've added a new variable locales_with_fake_bidi to fix that. Can you take
another look?

[Dirk Pranke, 2016-05-20 17:14:26]

lgtm

[sdefresne, 2016-05-20 17:14:51]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-05-20 17:14:51]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2003433003/#ps20001
(title: "Fix "analyse" by adding a new variable locales_with_fake_bidi")

[commit-bot: I haz the power, 2016-05-20 17:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003433003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003433003/20001

[commit-bot: I haz the power, 2016-05-20 19:05:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 19:06:24]

Description was changed from

==========
[GN] Use build/config/locales.gni to simplify grit invocations.

Uses the variables defined in build/config/locales.gni to simplify
the grit invocations and remove the conditional to deal with the
different names for the "es-419" and "pt-BR" locales on iOS.

BUG=525492
==========

to

==========
[GN] Use build/config/locales.gni to simplify grit invocations.

Uses the variables defined in build/config/locales.gni to simplify
the grit invocations and remove the conditional to deal with the
different names for the "es-419" and "pt-BR" locales on iOS.

BUG=525492

Committed: https://crrev.com/de51485fd1db9d4a22ce90764f767ad80e823acf
Cr-Commit-Position: refs/heads/master@{#395127}
==========

[commit-bot: I haz the power, 2016-05-20 19:06:25]

Patchset 2 (id:??) landed as
https://crrev.com/de51485fd1db9d4a22ce90764f767ad80e823acf
Cr-Commit-Position: refs/heads/master@{#395127}