Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: ui/strings/BUILD.gn

Issue 2003433003: [GN] Use build/config/locales.gni to simplify grit invocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@locale
Patch Set: Fix "analyse" by adding a new variable locales_with_fake_bidi Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libaddressinput/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/strings/BUILD.gn
diff --git a/ui/strings/BUILD.gn b/ui/strings/BUILD.gn
index b5f471a8cb001c8499acf939796f17597dfde509..a0be10ffbfe9fae45441dbc84f84f498e728b486 100644
--- a/ui/strings/BUILD.gn
+++ b/ui/strings/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/locales.gni")
import("//tools/grit/grit_rule.gni")
# Meta target that includes both ui_strings and app_locale_settings. Most
@@ -18,72 +19,9 @@ grit("ui_strings") {
use_qualified_include = true
outputs = [
"grit/ui_strings.h",
- "ui_strings_am.pak",
- "ui_strings_ar.pak",
- "ui_strings_bg.pak",
- "ui_strings_bn.pak",
- "ui_strings_ca.pak",
- "ui_strings_cs.pak",
- "ui_strings_da.pak",
- "ui_strings_de.pak",
- "ui_strings_el.pak",
- "ui_strings_en-GB.pak",
- "ui_strings_en-US.pak",
- "ui_strings_es.pak",
- "ui_strings_es-419.pak",
- "ui_strings_et.pak",
- "ui_strings_fa.pak",
- "ui_strings_fake-bidi.pak",
- "ui_strings_fi.pak",
- "ui_strings_fil.pak",
- "ui_strings_fr.pak",
- "ui_strings_gu.pak",
- "ui_strings_he.pak",
- "ui_strings_hi.pak",
- "ui_strings_hr.pak",
- "ui_strings_hu.pak",
- "ui_strings_id.pak",
- "ui_strings_it.pak",
- "ui_strings_ja.pak",
- "ui_strings_kn.pak",
- "ui_strings_ko.pak",
- "ui_strings_lt.pak",
- "ui_strings_lv.pak",
- "ui_strings_ml.pak",
- "ui_strings_mr.pak",
- "ui_strings_ms.pak",
- "ui_strings_nl.pak",
- "ui_strings_nb.pak",
- "ui_strings_pl.pak",
- "ui_strings_pt-BR.pak",
- "ui_strings_pt-PT.pak",
- "ui_strings_ro.pak",
- "ui_strings_ru.pak",
- "ui_strings_sk.pak",
- "ui_strings_sl.pak",
- "ui_strings_sr.pak",
- "ui_strings_sv.pak",
- "ui_strings_sw.pak",
- "ui_strings_ta.pak",
- "ui_strings_te.pak",
- "ui_strings_th.pak",
- "ui_strings_tr.pak",
- "ui_strings_uk.pak",
- "ui_strings_vi.pak",
- "ui_strings_zh-CN.pak",
- "ui_strings_zh-TW.pak",
]
-
- if (is_ios) {
- # iOS uses "pt" for pt-BR" and "es-MX" for "es-419".
- outputs -= [
- "ui_strings_pt-BR.pak",
- "ui_strings_es-419.pak",
- ]
- outputs += [
- "ui_strings_pt.pak",
- "ui_strings_es-MX.pak",
- ]
+ foreach(locale, locales_with_fake_bidi) {
+ outputs += [ "ui_strings_$locale.pak" ]
}
}
@@ -92,71 +30,8 @@ grit("app_locale_settings") {
use_qualified_include = true
outputs = [
"grit/app_locale_settings.h",
- "app_locale_settings_am.pak",
- "app_locale_settings_ar.pak",
- "app_locale_settings_bg.pak",
- "app_locale_settings_bn.pak",
- "app_locale_settings_ca.pak",
- "app_locale_settings_cs.pak",
- "app_locale_settings_da.pak",
- "app_locale_settings_de.pak",
- "app_locale_settings_el.pak",
- "app_locale_settings_en-GB.pak",
- "app_locale_settings_en-US.pak",
- "app_locale_settings_es.pak",
- "app_locale_settings_es-419.pak",
- "app_locale_settings_et.pak",
- "app_locale_settings_fa.pak",
- "app_locale_settings_fake-bidi.pak",
- "app_locale_settings_fi.pak",
- "app_locale_settings_fil.pak",
- "app_locale_settings_fr.pak",
- "app_locale_settings_gu.pak",
- "app_locale_settings_he.pak",
- "app_locale_settings_hi.pak",
- "app_locale_settings_hr.pak",
- "app_locale_settings_hu.pak",
- "app_locale_settings_id.pak",
- "app_locale_settings_it.pak",
- "app_locale_settings_ja.pak",
- "app_locale_settings_kn.pak",
- "app_locale_settings_ko.pak",
- "app_locale_settings_lt.pak",
- "app_locale_settings_lv.pak",
- "app_locale_settings_ml.pak",
- "app_locale_settings_mr.pak",
- "app_locale_settings_ms.pak",
- "app_locale_settings_nl.pak",
- "app_locale_settings_nb.pak",
- "app_locale_settings_pl.pak",
- "app_locale_settings_pt-BR.pak",
- "app_locale_settings_pt-PT.pak",
- "app_locale_settings_ro.pak",
- "app_locale_settings_ru.pak",
- "app_locale_settings_sk.pak",
- "app_locale_settings_sl.pak",
- "app_locale_settings_sr.pak",
- "app_locale_settings_sv.pak",
- "app_locale_settings_sw.pak",
- "app_locale_settings_ta.pak",
- "app_locale_settings_te.pak",
- "app_locale_settings_th.pak",
- "app_locale_settings_tr.pak",
- "app_locale_settings_uk.pak",
- "app_locale_settings_vi.pak",
- "app_locale_settings_zh-CN.pak",
- "app_locale_settings_zh-TW.pak",
]
-
- if (is_ios) {
- # iOS uses "pt" for pt-BR" and "es-MX" for "es-419".
- outputs -= [
- "app_locale_settings_pt-BR.pak",
- "app_locale_settings_es-419.pak",
- ]
- outputs += [
- "app_locale_settings_pt.pak",
- "app_locale_settings_es-MX.pak",
- ]
+ foreach(locale, locales_with_fake_bidi) {
+ outputs += [ "app_locale_settings_$locale.pak" ]
}
}
« no previous file with comments | « third_party/libaddressinput/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698