Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2000603002: [iOS/GN] Update build/config/locales.gni for Chrome on iOS. (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Update build/config/locales.gni for Chrome on iOS. Chrome on iOS only ships with a subset of locales compared to Chrome (as the corresponding locales are not supported by the system) and uses different names for "es-419" and "pt-BR". BUG=459705, 525492 Committed: https://crrev.com/23deef3518c543a32ef86a5839d778931b37fef3 Cr-Commit-Position: refs/heads/master@{#395095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4 lines) Patch
M build/config/locales.gni View 7 chunks +59 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 7 months ago (2016-05-20 10:24:54 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-20 16:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000603002/20001
4 years, 7 months ago (2016-05-20 16:31:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-20 16:39:22 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 16:41:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23deef3518c543a32ef86a5839d778931b37fef3
Cr-Commit-Position: refs/heads/master@{#395095}

Powered by Google App Engine
This is Rietveld 408576698