Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 2003433003: [GN] Use build/config/locales.gni to simplify grit invocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@locale
Patch Set: Fix "analyse" by adding a new variable locales_with_fake_bidi Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/strings/BUILD.gn ('k') | ui/strings/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/BUILD.gn
diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn
index 864e79003ca96b1426689a3032db6c7e20bc2da6..b2bc605a7bd56133533761f6aaaad3e18b32ffee 100644
--- a/third_party/libaddressinput/BUILD.gn
+++ b/third_party/libaddressinput/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//testing/test.gni")
+import("//build/config/locales.gni")
import("//tools/grit/grit_rule.gni")
libaddressinput_util_files = [
@@ -36,72 +37,9 @@ grit("strings") {
outputs = [
"messages.h",
"en_messages.cc",
- "address_input_strings_am.pak",
- "address_input_strings_ar.pak",
- "address_input_strings_bg.pak",
- "address_input_strings_bn.pak",
- "address_input_strings_ca.pak",
- "address_input_strings_cs.pak",
- "address_input_strings_da.pak",
- "address_input_strings_de.pak",
- "address_input_strings_el.pak",
- "address_input_strings_en-GB.pak",
- "address_input_strings_en-US.pak",
- "address_input_strings_es.pak",
- "address_input_strings_es-419.pak",
- "address_input_strings_et.pak",
- "address_input_strings_fa.pak",
- "address_input_strings_fake-bidi.pak",
- "address_input_strings_fi.pak",
- "address_input_strings_fil.pak",
- "address_input_strings_fr.pak",
- "address_input_strings_gu.pak",
- "address_input_strings_he.pak",
- "address_input_strings_hi.pak",
- "address_input_strings_hr.pak",
- "address_input_strings_hu.pak",
- "address_input_strings_id.pak",
- "address_input_strings_it.pak",
- "address_input_strings_ja.pak",
- "address_input_strings_kn.pak",
- "address_input_strings_ko.pak",
- "address_input_strings_lt.pak",
- "address_input_strings_lv.pak",
- "address_input_strings_ml.pak",
- "address_input_strings_mr.pak",
- "address_input_strings_ms.pak",
- "address_input_strings_nl.pak",
- "address_input_strings_nb.pak",
- "address_input_strings_pl.pak",
- "address_input_strings_pt-BR.pak",
- "address_input_strings_pt-PT.pak",
- "address_input_strings_ro.pak",
- "address_input_strings_ru.pak",
- "address_input_strings_sk.pak",
- "address_input_strings_sl.pak",
- "address_input_strings_sr.pak",
- "address_input_strings_sv.pak",
- "address_input_strings_sw.pak",
- "address_input_strings_ta.pak",
- "address_input_strings_te.pak",
- "address_input_strings_th.pak",
- "address_input_strings_tr.pak",
- "address_input_strings_uk.pak",
- "address_input_strings_vi.pak",
- "address_input_strings_zh-CN.pak",
- "address_input_strings_zh-TW.pak",
]
-
- if (is_ios) {
- # iOS uses "pt" for pt-BR" and "es-MX" for "es-419".
- outputs -= [
- "address_input_strings_pt-BR.pak",
- "address_input_strings_es-419.pak",
- ]
- outputs += [
- "address_input_strings_pt.pak",
- "address_input_strings_es-MX.pak",
- ]
+ foreach(locale, locales_with_fake_bidi) {
+ outputs += [ "address_input_strings_$locale.pak" ]
}
configs = [ ":no-newline-eof-warning" ]
« no previous file with comments | « ios/chrome/app/strings/BUILD.gn ('k') | ui/strings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698