Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2001523002: GYP changes for arm64 linux build (Closed)

Created:
4 years, 7 months ago by apatole
Modified:
4 years, 6 months ago
Reviewers:
Nico, fbarchard
CC:
chromium-reviews, jzern, skal, urvang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GYP changes for arm64 linux build This change adds support for cross compiling chrome on ARM64 linux. Temporarily disabled nacl and tcmalloc to fix compilation errors. BUG=613452 Committed: https://crrev.com/3026e6886f052160a3ff594801d5b4dbe8a20753 Cr-Commit-Position: refs/heads/master@{#399766}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporating review comments related to libwebp changes #

Total comments: 5

Patch Set 3 : Add GN Build changes + Incorporate review comments #

Total comments: 6

Patch Set 4 : Added comments related to disabling nacl and tcmalloc in GN files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M build/common.gypi View 1 2 3 chunks +19 lines, -0 lines 0 comments Download
M build/config/allocator.gni View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M build/config/sysroot.gni View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libwebp/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libwebp/libwebp.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (5 generated)
apatole
On 2016/05/24 06:31:19, apatole wrote: > mailto:apatole@nvidia.com changed reviewers: > + mailto:fbarchard@chromium.org, mailto:thakis@chromium.org Hi Reviewers, ...
4 years, 6 months ago (2016-05-30 08:42:41 UTC) #3
jzern
https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp.gyp File third_party/libwebp/libwebp.gyp (right): https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp.gyp#newcode184 third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and OS == "android"', { you ...
4 years, 6 months ago (2016-05-31 23:37:16 UTC) #4
apatole
https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp.gyp File third_party/libwebp/libwebp.gyp (right): https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp.gyp#newcode184 third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and OS == "android"', { On ...
4 years, 6 months ago (2016-06-01 05:25:42 UTC) #5
apatole
On 2016/06/01 05:25:42, apatole wrote: > https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp.gyp > File third_party/libwebp/libwebp.gyp (right): > > https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp.gyp#newcode184 > ...
4 years, 6 months ago (2016-06-02 13:30:11 UTC) #6
Nico
Do you want to change any .gn files as well? https://codereview.chromium.org/2001523002/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2001523002/diff/20001/build/common.gypi#newcode307 ...
4 years, 6 months ago (2016-06-02 17:57:25 UTC) #7
apatole
Hi, thanks for the review! > Do you want to change any .gn files as ...
4 years, 6 months ago (2016-06-03 06:11:47 UTC) #8
apatole
Added GN build support for arm64 linux. https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/libwebp.gyp File third_party/libwebp/libwebp.gyp (right): https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/libwebp.gyp#newcode184 third_party/libwebp/libwebp.gyp:184: ['target_arch == ...
4 years, 6 months ago (2016-06-03 11:33:44 UTC) #9
jzern
https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/README.chromium#newcode24 third_party/libwebp/README.chromium:24: * Disabled "-frename-registers" flag for ARM64 linux build as ...
4 years, 6 months ago (2016-06-03 17:56:19 UTC) #10
apatole
https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/README.chromium#newcode24 third_party/libwebp/README.chromium:24: * Disabled "-frename-registers" flag for ARM64 linux build as ...
4 years, 6 months ago (2016-06-03 18:06:48 UTC) #11
Nico
Thanks! This lgtm except for the jessie bit (but let's discuss that part in the ...
4 years, 6 months ago (2016-06-04 01:18:24 UTC) #12
apatole
OK Thanks, will wait for conclusion regarding wheezy/jessie on other patch and then commit/modify this ...
4 years, 6 months ago (2016-06-06 06:40:00 UTC) #13
apatole
Nico, Let me know if you have any comments related to Jessie sysroot after recent ...
4 years, 6 months ago (2016-06-14 11:51:55 UTC) #14
Nico
lgtm, makes sense as far as I understand.
4 years, 6 months ago (2016-06-14 13:16:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001523002/60001
4 years, 6 months ago (2016-06-14 15:23:12 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-14 19:42:37 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 19:43:58 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3026e6886f052160a3ff594801d5b4dbe8a20753
Cr-Commit-Position: refs/heads/master@{#399766}

Powered by Google App Engine
This is Rietveld 408576698