GYP changes for arm64 linux build

GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452
Committed: https://crrev.com/3026e6886f052160a3ff594801d5b4dbe8a20753
Cr-Commit-Position: refs/heads/master@{#399766}

[apatole, 2016-05-24 06:31:19]

Description was changed from

==========
GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452
==========

to

==========
GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452
==========

[apatole, 2016-05-24 06:31:19]

apatole@nvidia.com changed reviewers:
+ fbarchard@chromium.org, thakis@chromium.org

[apatole, 2016-05-30 08:42:41]

On 2016/05/24 06:31:19, apatole wrote:
> mailto:apatole@nvidia.com changed reviewers:
> + mailto:fbarchard@chromium.org, mailto:thakis@chromium.org

Hi Reviewers, please review and provide your comments, let me know if I need to
add any other reviewer.

[jzern, 2016-05-31 23:37:16]

https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp...
File third_party/libwebp/libwebp.gyp (right):

https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp...
third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and OS ==
"android"', {
you should be able to check is_clang, not sure if there's an is_gcc

[apatole, 2016-06-01 05:25:42]

https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp...
File third_party/libwebp/libwebp.gyp (right):

https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp...
third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and OS ==
"android"', {
On 2016/05/31 23:37:15, jzern wrote:
> you should be able to check is_clang, not sure if there's an is_gcc

OK, thanks for review, will check how it can be reused. I added "OS == android"
check as I thought android is the only arm64 target other than linux.

[apatole, 2016-06-02 13:30:11]

On 2016/06/01 05:25:42, apatole wrote:
>
https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp...
> File third_party/libwebp/libwebp.gyp (right):
> 
>
https://codereview.chromium.org/2001523002/diff/1/third_party/libwebp/libwebp...
> third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and OS ==
> "android"', {
> On 2016/05/31 23:37:15, jzern wrote:
> > you should be able to check is_clang, not sure if there's an is_gcc
> 
> OK, thanks for review, will check how it can be reused. I added "OS ==
android"
> check as I thought android is the only arm64 target other than linux.

Done! I have added explicit linux + clang check which looks more appropriate
than android check.

[Nico, 2016-06-02 17:57:25]

Do you want to change any .gn files as well?

https://codereview.chromium.org/2001523002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2001523002/diff/20001/build/common.gypi#newco...
build/common.gypi:307: 'sysroot%': '<!(cd <(DEPTH) && pwd
-P)/build/linux/debian_jessie_arm64-sysroot',
why jessie?

(also, build/linux/sysroot_scripts/install-sysroot.py doesn't download the arm64
sysroot on linux atm ... are you changing that in a separate cl?)

https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/lib...
File third_party/libwebp/libwebp.gyp (right):

https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/lib...
third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and not (OS ==
"linux" and clang == 1)', {
I think you can just add `and clang!=1` here. You don't need a new comment
either: The existing comment already says this works around a gcc bug, it makes
sense that clang doesn't have gcc bugs :-)

[apatole, 2016-06-03 06:11:47]

Hi, thanks for the review!

> Do you want to change any .gn files as well?
Ok, I was not aware of gn files, will look at gn files as well.

https://codereview.chromium.org/2001523002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2001523002/diff/20001/build/common.gypi#newco...
build/common.gypi:307: 'sysroot%': '<!(cd <(DEPTH) && pwd
-P)/build/linux/debian_jessie_arm64-sysroot',
On 2016/06/02 17:57:24, Nico wrote:
> why jessie?
> 
> (also, build/linux/sysroot_scripts/install-sysroot.py doesn't download the
arm64
> sysroot on linux atm ... are you changing that in a separate cl?)

Hi, I explained it on https://codereview.chromium.org/1997993003/, let me know
if it still makes sense to have wheezy.

Regarding install-sysroot script, yes I am going to have another patch for it.
Before making change for installing arm64 sysroot. I will have to get help from
someone to upload sysroot to google cloud, I do not have required permissions.

https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/lib...
File third_party/libwebp/libwebp.gyp (right):

https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/lib...
third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and not (OS ==
"linux" and clang == 1)', {
On 2016/06/02 17:57:24, Nico wrote:
> I think you can just add `and clang!=1` here. You don't need a new comment
> either: The existing comment already says this works around a gcc bug, it
makes
> sense that clang doesn't have gcc bugs :-)

OK, will do.

[apatole, 2016-06-03 11:33:44]

Added GN build support for arm64 linux.

https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/lib...
File third_party/libwebp/libwebp.gyp (right):

https://codereview.chromium.org/2001523002/diff/20001/third_party/libwebp/lib...
third_party/libwebp/libwebp.gyp:184: ['target_arch == "arm64" and not (OS ==
"linux" and clang == 1)', {
On 2016/06/02 17:57:24, Nico wrote:
> I think you can just add `and clang!=1` here. You don't need a new comment
> either: The existing comment already says this works around a gcc bug, it
makes
> sense that clang doesn't have gcc bugs :-)

Done.

[jzern, 2016-06-03 17:56:19]

https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/REA...
File third_party/libwebp/README.chromium (right):

https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/REA...
third_party/libwebp/README.chromium:24: * Disabled "-frename-registers" flag for
ARM64 linux build as clang(3.9.0)
we don't carry the gyp/gn files upstream, so a note isn't necessary. the change
itself is documentation enough.

[apatole, 2016-06-03 18:06:48]

https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/REA...
File third_party/libwebp/README.chromium (right):

https://codereview.chromium.org/2001523002/diff/40001/third_party/libwebp/REA...
third_party/libwebp/README.chromium:24: * Disabled "-frename-registers" flag for
ARM64 linux build as clang(3.9.0)
On 2016/06/03 17:56:19, jzern wrote:
> we don't carry the gyp/gn files upstream, so a note isn't necessary. the
change
> itself is documentation enough.

Ok, I got warning while presubmit and it suggested to add the description in
readme so I added it.

[Nico, 2016-06-04 01:18:24]

Thanks! This lgtm except for the jessie bit (but let's discuss that part in the
other review)

https://codereview.chromium.org/2001523002/diff/40001/build/config/allocator.gni
File build/config/allocator.gni (right):

https://codereview.chromium.org/2001523002/diff/40001/build/config/allocator....
build/config/allocator.gni:9: (is_linux && target_cpu == "arm64")) {
add a comment here saying this is temporary for linux/arm64 (like in the gyp
file)

https://codereview.chromium.org/2001523002/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/2001523002/diff/40001/build/config/features.g...
build/config/features.gni:34: current_cpu != "mipsel" && !(is_linux &&
target_cpu == "arm64")
add a comment here too

[apatole, 2016-06-06 06:40:00]

OK Thanks, will wait for conclusion regarding wheezy/jessie on other patch and
then commit/modify this patch accordingly.

https://codereview.chromium.org/2001523002/diff/40001/build/config/allocator.gni
File build/config/allocator.gni (right):

https://codereview.chromium.org/2001523002/diff/40001/build/config/allocator....
build/config/allocator.gni:9: (is_linux && target_cpu == "arm64")) {
On 2016/06/04 01:18:24, Nico wrote:
> add a comment here saying this is temporary for linux/arm64 (like in the gyp
> file)

Done.

https://codereview.chromium.org/2001523002/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/2001523002/diff/40001/build/config/features.g...
build/config/features.gni:34: current_cpu != "mipsel" && !(is_linux &&
target_cpu == "arm64")
On 2016/06/04 01:18:24, Nico wrote:
> add a comment here too

Done.

[apatole, 2016-06-14 11:51:55]

Nico,
Let me know if you have any comments related to Jessie sysroot after recent
comments at https://codereview.chromium.org/1997993003/

[Nico, 2016-06-14 13:16:41]

lgtm, makes sense as far as I understand.

[apatole, 2016-06-14 15:22:42]

The CQ bit was checked by apatole@nvidia.com

[commit-bot: I haz the power, 2016-06-14 15:23:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001523002/60001

[commit-bot: I haz the power, 2016-06-14 19:42:34]

Description was changed from

==========
GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452
==========

to

==========
GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452
==========

[commit-bot: I haz the power, 2016-06-14 19:42:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-14 19:43:57]

Description was changed from

==========
GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452
==========

to

==========
GYP changes for arm64 linux build

This change adds support for cross compiling chrome on ARM64 linux.
Temporarily disabled nacl and tcmalloc to fix compilation errors.

BUG=613452

Committed: https://crrev.com/3026e6886f052160a3ff594801d5b4dbe8a20753
Cr-Commit-Position: refs/heads/master@{#399766}
==========

[commit-bot: I haz the power, 2016-06-14 19:43:58]

Patchset 4 (id:??) landed as
https://crrev.com/3026e6886f052160a3ff594801d5b4dbe8a20753
Cr-Commit-Position: refs/heads/master@{#399766}