Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: build/config/allocator.gni

Issue 2001523002: GYP changes for arm64 linux build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comments related to disabling nacl and tcmalloc in GN files. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 6
7 # Temporarily disable tcmalloc on arm64 linux to get rid of compilation errors.
7 if (is_android || current_cpu == "mipsel" || is_mac || is_ios || is_asan || 8 if (is_android || current_cpu == "mipsel" || is_mac || is_ios || is_asan ||
8 is_lsan || is_tsan || is_msan || is_win || is_syzyasan) { 9 is_lsan || is_tsan || is_msan || is_win || is_syzyasan ||
10 (is_linux && target_cpu == "arm64")) {
9 _default_allocator = "none" 11 _default_allocator = "none"
10 } else { 12 } else {
11 _default_allocator = "tcmalloc" 13 _default_allocator = "tcmalloc"
12 } 14 }
13 15
14 if ((is_linux || is_android) && !is_asan && !is_lsan && !is_tsan && !is_msan) { 16 if ((is_linux || is_android) && !is_asan && !is_lsan && !is_tsan && !is_msan) {
15 _default_use_experimental_allocator_shim = true 17 _default_use_experimental_allocator_shim = true
16 } else { 18 } else {
17 _default_use_experimental_allocator_shim = false 19 _default_use_experimental_allocator_shim = false
18 } 20 }
19 21
20 declare_args() { 22 declare_args() {
21 # Memory allocator to use. Set to "none" to use default allocator. 23 # Memory allocator to use. Set to "none" to use default allocator.
22 use_allocator = _default_allocator 24 use_allocator = _default_allocator
23 25
24 # TODO(primiano): this should just become the default without having a flag, 26 # TODO(primiano): this should just become the default without having a flag,
25 # but we need to get there first. http://crbug.com/550886 . 27 # but we need to get there first. http://crbug.com/550886 .
26 # Causes all the allocations to be routed via allocator_shim.cc. 28 # Causes all the allocations to be routed via allocator_shim.cc.
27 use_experimental_allocator_shim = _default_use_experimental_allocator_shim 29 use_experimental_allocator_shim = _default_use_experimental_allocator_shim
28 } 30 }
29 31
30 assert(use_allocator == "none" || use_allocator == "tcmalloc") 32 assert(use_allocator == "none" || use_allocator == "tcmalloc")
31 33
32 assert(!is_win || use_allocator == "none", "Tcmalloc doesn't work on Windows.") 34 assert(!is_win || use_allocator == "none", "Tcmalloc doesn't work on Windows.")
33 assert( 35 assert(
34 !use_experimental_allocator_shim || is_linux || is_android, 36 !use_experimental_allocator_shim || is_linux || is_android,
35 "use_experimental_allocator_shim supported only on Linux and Android targets ") 37 "use_experimental_allocator_shim supported only on Linux and Android targets ")
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698