build/config/features.gni - Issue 2001523002: GYP changes for arm64 linux build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/features.gni

Issue 2001523002: GYP changes for arm64 linux build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments related to disabling nacl and tcmalloc in GN files. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/features.gni

diff --git a/build/config/features.gni b/build/config/features.gni

index e1c8847f25bbde7175f77954ce27b9fb4f138f5d..1850e19d4e9add904cd1dd83598b4451a2c0de43 100644

--- a/build/config/features.gni

+++ b/build/config/features.gni

@@ -29,9 +29,10 @@ declare_args() {

enable_pdf = !is_android && !is_ios && !is_chromecast

# Enables Native Client support.

+ # Temporarily disable nacl on arm64 linux to get rid of compilation errors.

# TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion.

- enable_nacl =

- !is_ios && !is_android && !is_chromecast && current_cpu != "mipsel"

+ enable_nacl = !is_ios && !is_android && !is_chromecast &&

+ current_cpu != "mipsel" && !(is_linux && target_cpu == "arm64")

# If debug_devtools is set to true, JavaScript files for DevTools are stored

# as is and loaded from disk. Otherwise, a concatenated file is stored in

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/sysroot.gni » ('j') | no next file with comments »