Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Side by Side Diff: build/config/features.gni

Issue 2001523002: GYP changes for arm64 linux build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add GN Build changes + Incorporate review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains Chrome-feature-related build flags (see ui.gni for 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # UI-related ones). These should theoretically be moved to the build files of 6 # UI-related ones). These should theoretically be moved to the build files of
7 # the features themselves. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
(...skipping 12 matching lines...) Expand all
23 declare_args() { 23 declare_args() {
24 # Multicast DNS. 24 # Multicast DNS.
25 enable_mdns = is_win || is_linux 25 enable_mdns = is_win || is_linux
26 26
27 enable_extensions = !is_android && !is_ios 27 enable_extensions = !is_android && !is_ios
28 enable_plugins = (!is_android && !is_ios) || is_chromecast 28 enable_plugins = (!is_android && !is_ios) || is_chromecast
29 enable_pdf = !is_android && !is_ios && !is_chromecast 29 enable_pdf = !is_android && !is_ios && !is_chromecast
30 30
31 # Enables Native Client support. 31 # Enables Native Client support.
32 # TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion. 32 # TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion.
33 enable_nacl = 33 enable_nacl = !is_ios && !is_android && !is_chromecast &&
34 !is_ios && !is_android && !is_chromecast && current_cpu != "mipsel" 34 current_cpu != "mipsel" && !(is_linux && target_cpu == "arm64")
Nico 2016/06/04 01:18:24 add a comment here too
apatole 2016/06/06 06:40:00 Done.
35 35
36 # If debug_devtools is set to true, JavaScript files for DevTools are stored 36 # If debug_devtools is set to true, JavaScript files for DevTools are stored
37 # as is and loaded from disk. Otherwise, a concatenated file is stored in 37 # as is and loaded from disk. Otherwise, a concatenated file is stored in
38 # resources.pak. It is still possible to load JS files from disk by passing 38 # resources.pak. It is still possible to load JS files from disk by passing
39 # --debug-devtools cmdline switch. 39 # --debug-devtools cmdline switch.
40 debug_devtools = false 40 debug_devtools = false
41 41
42 # Enables WebRTC. 42 # Enables WebRTC.
43 enable_webrtc = !is_ios 43 enable_webrtc = !is_ios
44 44
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 use_brlapi = is_chromeos 166 use_brlapi = is_chromeos
167 167
168 # Enable WebVR support by default on Android 168 # Enable WebVR support by default on Android
169 # Still requires command line flag to access API 169 # Still requires command line flag to access API
170 enable_webvr = is_android 170 enable_webvr = is_android
171 171
172 enable_configuration_policy = !is_ios 172 enable_configuration_policy = !is_ios
173 173
174 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 174 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
175 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build 175 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698