Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001183002: Deprecate FLAGS_quic_simplify_loss_detection. (Closed)

Created:
4 years, 7 months ago by Fan Yang
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@122429210
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate FLAGS_quic_simplify_loss_detection. Merge internal change: 122481524 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -110 lines) Patch
M net/quic/congestion_control/general_loss_algorithm.cc View 4 chunks +2 lines, -29 lines 0 comments Download
M net/quic/congestion_control/general_loss_algorithm_test.cc View 12 chunks +0 lines, -47 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +1 line, -15 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 2002103002 Patch 1

Dependent Patchsets:

Issue 2007223002 Patch 1
Issue 2007223002 Patch 20001

Messages

Total messages: 7 (3 generated)
Fan Yang
4 years, 7 months ago (2016-05-23 16:33:29 UTC) #2
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-23 16:43:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001183002/1
4 years, 7 months ago (2016-05-26 00:57:42 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 01:17:36 UTC) #7 
Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

Powered by Google App Engine
This is Rietveld 408576698