Issue 2007223002: Explicitly disallow multi-packet CHLOs. Protected by FLAGS_quic_disallow_multi_packet_chlo, default…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2007223002: Explicitly disallow multi-packet CHLOs. Protected by FLAGS_quic_disallow_multi_packet_chlo, default… (Closed)

Created:
4 years, 7 months ago by Fan Yang

Modified:
4 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@122481524

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Explicitly disallow multi-packet CHLOs. Protected by FLAGS_quic_disallow_multi_packet_chlo, default true. Merge internal change: 122546126 R=rch@chromium.org BUG=

Patch Set 2 : remove static_cast #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
M	net/quic/quic_flags.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	net/quic/quic_protocol.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_utils.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2001183002 Patch 1

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/2007223002/diff/1/net/quic/quic_packet_creator.cc File net/quic/quic_packet_creator.cc (right): https://codereview.chromium.org/2007223002/diff/1/net/quic/quic_packet_creator.cc#newcode174 net/quic/quic_packet_creator.cc:174: DCHECK_EQ(static_cast<size_t>(0), iov_offset); nit: instead of static cast, can ...

4 years, 7 months ago (2016-05-25 02:29:20 UTC) #2

Fan Yang

4 years, 7 months ago (2016-05-25 13:48:19 UTC) #3

On 2016/05/25 02:29:20, Ryan Hamilton wrote:
> lgtm
> 
>
https://codereview.chromium.org/2007223002/diff/1/net/quic/quic_packet_creato...
> File net/quic/quic_packet_creator.cc (right):
> 
>
https://codereview.chromium.org/2007223002/diff/1/net/quic/quic_packet_creato...
> net/quic/quic_packet_creator.cc:174: DCHECK_EQ(static_cast<size_t>(0),
> iov_offset);
> nit: instead of static cast, can you just do 0u?

Done. Thanks, Ryan.

Expand Messages | Collapse Messages

Issue 2007223002: Explicitly disallow multi-packet CHLOs. Protected by FLAGS_quic_disallow_multi_packet_chlo, default… (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove static_cast #

Messages