Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: net/quic/congestion_control/general_loss_algorithm.cc

Issue 2001183002: Deprecate FLAGS_quic_simplify_loss_detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@122429210
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/congestion_control/general_loss_algorithm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/general_loss_algorithm.cc
diff --git a/net/quic/congestion_control/general_loss_algorithm.cc b/net/quic/congestion_control/general_loss_algorithm.cc
index bcd2b49eecb04c7fa010cce7a30e62b294f16271..85b8e621742734f65fa9baf5d0f499269308ad23 100644
--- a/net/quic/congestion_control/general_loss_algorithm.cc
+++ b/net/quic/congestion_control/general_loss_algorithm.cc
@@ -78,7 +78,7 @@ void GeneralLossAlgorithm::DetectLosses(
continue;
}
- if (FLAGS_quic_simplify_loss_detection && loss_type_ == kNack) {
+ if (loss_type_ == kNack) {
// FACK based loss detection.
if (largest_observed - packet_number >=
kNumberOfNacksBeforeRetransmission) {
@@ -90,8 +90,7 @@ void GeneralLossAlgorithm::DetectLosses(
// Only early retransmit(RFC5827) when the last packet gets acked and
// there are retransmittable packets in flight.
// This also implements a timer-protected variant of FACK.
- if ((FLAGS_quic_simplify_loss_detection &&
- !it->retransmittable_frames.empty() &&
+ if ((!it->retransmittable_frames.empty() &&
unacked_packets.largest_sent_packet() == largest_observed) ||
(loss_type_ == kTime || loss_type_ == kAdaptiveTime)) {
QuicTime when_lost = it->sent_time.Add(loss_delay);
@@ -102,17 +101,6 @@ void GeneralLossAlgorithm::DetectLosses(
packets_lost->push_back(std::make_pair(packet_number, it->bytes_sent));
continue;
}
- if (!FLAGS_quic_simplify_loss_detection) {
- // FACK based loss detection.
- QUIC_BUG_IF(it->nack_count == 0 && it->sent_time.IsInitialized())
- << "All packets less than largest observed should have been nacked."
- << " packet_number:" << packet_number
- << " largest_observed:" << largest_observed;
- if (it->nack_count >= kNumberOfNacksBeforeRetransmission) {
- packets_lost->push_back(std::make_pair(packet_number, it->bytes_sent));
- continue;
- }
- }
// NACK-based loss detection allows for a max reordering window of 1 RTT.
if (it->sent_time.Add(rtt_stats.smoothed_rtt()) <
@@ -120,21 +108,6 @@ void GeneralLossAlgorithm::DetectLosses(
packets_lost->push_back(std::make_pair(packet_number, it->bytes_sent));
continue;
}
-
- if (!FLAGS_quic_simplify_loss_detection &&
- !it->retransmittable_frames.empty() &&
- unacked_packets.largest_sent_packet() == largest_observed) {
- // Early retransmit marks the packet as lost once 1.25RTTs have passed
- // since the packet was sent and otherwise sets an alarm.
- if (time >= it->sent_time.Add(loss_delay)) {
- packets_lost->push_back(std::make_pair(packet_number, it->bytes_sent));
- } else {
- // Set the timeout for the earliest retransmittable packet where early
- // retransmit applies.
- loss_detection_timeout_ = it->sent_time.Add(loss_delay);
- break;
- }
- }
}
}
« no previous file with comments | « no previous file | net/quic/congestion_control/general_loss_algorithm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698