Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 2001183002: Deprecate FLAGS_quic_simplify_loss_detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@122429210
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_unacked_packet_map.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 9d4f694376a6bcf0c0903ab264a54e2863bf603c..28c32c05da251bb5683be25399d20cac6ae1c157 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -320,21 +320,7 @@ void QuicSentPacketManager::HandleAckForSentPackets(
if ((ack_frame.missing && ack_frame.packets.Contains(packet_number)) ||
(!ack_frame.missing && !ack_frame.packets.Contains(packet_number))) {
- // Don't continue to increase the nack count for packets not in flight.
- if (FLAGS_quic_simplify_loss_detection || !it->in_flight) {
- continue;
- }
- // Consider it multiple nacks when there is a gap between the missing
- // packet and the largest observed, since the purpose of a nack
- // threshold is to tolerate re-ordering. This handles both StretchAcks
- // and Forward Acks.
- // The nack count only increases when the largest observed increases.
- QuicPacketCount min_nacks = ack_frame.largest_observed - packet_number;
- // Truncated acks can nack the largest observed, so use a min of 1.
- if (min_nacks == 0) {
- min_nacks = 1;
- }
- unacked_packets_.NackPacket(packet_number, min_nacks);
+ // Packet is still missing.
continue;
}
// Packet was acked, so remove it from our unacked packet list.
« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_unacked_packet_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698