Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2000973002: Make CPDF_Function::Load() return an unique_ptr. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_Function::Load() return an unique_ptr. Committed: https://pdfium.googlesource.com/pdfium/+/490d6128e6faef423fa6f965f792513e138bc04a

Patch Set 1 : #

Patch Set 2 : private #

Total comments: 18

Patch Set 3 : address comments #

Patch Set 4 : rebase #

Total comments: 3

Patch Set 5 : fix build, nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -402 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 7 chunks +48 lines, -57 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_meshstream.h View 1 3 chunks +15 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_meshstream.cpp View 1 2 3 4 4 chunks +23 lines, -28 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.h View 1 5 chunks +15 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.cpp View 3 chunks +7 lines, -18 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 7 chunks +28 lines, -30 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 2 3 4 25 chunks +223 lines, -233 lines 0 comments Download
M core/fpdfapi/fpdf_render/render_int.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Lei Zhang
4 years, 7 months ago (2016-05-23 16:19:41 UTC) #3
Lei Zhang
4 years, 7 months ago (2016-05-23 18:28:09 UTC) #5
Tom Sepez
Mostly nits. https://codereview.chromium.org/2000973002/diff/40001/core/fpdfapi/fpdf_page/cpdf_colorspace.cpp File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right): https://codereview.chromium.org/2000973002/diff/40001/core/fpdfapi/fpdf_page/cpdf_colorspace.cpp#newcode229 core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:229: class CPDF_DeviceNCS : public CPDF_ColorSpace { Curious, ...
4 years, 7 months ago (2016-05-23 19:09:34 UTC) #6
Lei Zhang
https://codereview.chromium.org/2000973002/diff/40001/core/fpdfapi/fpdf_page/cpdf_colorspace.cpp File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right): https://codereview.chromium.org/2000973002/diff/40001/core/fpdfapi/fpdf_page/cpdf_colorspace.cpp#newcode229 core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:229: class CPDF_DeviceNCS : public CPDF_ColorSpace { On 2016/05/23 19:09:33, ...
4 years, 7 months ago (2016-05-23 19:26:21 UTC) #7
Tom Sepez
LGTM with nit once bots are green. https://codereview.chromium.org/2000973002/diff/80001/core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp File core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right): https://codereview.chromium.org/2000973002/diff/80001/core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp#newcode729 core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:729: bool bCoorBitsValid ...
4 years, 7 months ago (2016-05-23 20:34:42 UTC) #8
Lei Zhang
https://codereview.chromium.org/2000973002/diff/80001/core/fpdfapi/fpdf_page/cpdf_meshstream.cpp File core/fpdfapi/fpdf_page/cpdf_meshstream.cpp (right): https://codereview.chromium.org/2000973002/diff/80001/core/fpdfapi/fpdf_page/cpdf_meshstream.cpp#newcode71 core/fpdfapi/fpdf_page/cpdf_meshstream.cpp:71: for (int i = 0; i < m_nComps; i++) ...
4 years, 7 months ago (2016-05-23 21:39:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000973002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000973002/100001
4 years, 7 months ago (2016-05-23 21:40:05 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 21:56:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/490d6128e6faef423fa6f965f792513e138b...

Powered by Google App Engine
This is Rietveld 408576698