core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp - Issue 2000973002: Make CPDF_Function::Load() return an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

Issue 2000973002: Make CPDF_Function::Load() return an unique_ptr. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: fix build, nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

diff --git a/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp b/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

index 08581322916bd2361aa775ff79c2bdcf68ff8f29..de84f298650df2ecdaba93ee2fd702e8f18b546c 100644

--- a/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

+++ b/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

@@ -22,7 +22,7 @@ CPDF_ShadingObject* CPDF_ShadingObject::Clone() const {

if (obj->m_pShading && obj->m_pShading->document()) {

CPDF_DocPageData* pDocPageData = obj->m_pShading->document()->GetPageData();

CPDF_Pattern* pattern = pDocPageData->GetPattern(

- obj->m_pShading->m_pShadingObj, m_pShading->m_bShadingObj,

+ obj->m_pShading->GetShadingObject(), m_pShading->IsShadingObject(),

obj->m_pShading->parent_matrix());

obj->m_pShading = pattern ? pattern->AsShadingPattern() : nullptr;

}