Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Unified Diff: content/public/child/v8_value_converter.h

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/child/v8_value_converter.h
diff --git a/content/public/child/v8_value_converter.h b/content/public/child/v8_value_converter.h
index a7a0e8946f0806772687d78bfe0d1b03cf58ae33..67e3025ff1a6beb68f0d32d4a193584deb007cb2 100644
--- a/content/public/child/v8_value_converter.h
+++ b/content/public/child/v8_value_converter.h
@@ -105,6 +105,7 @@ class CONTENT_EXPORT V8ValueConverter {
// Unsupported types are replaced with null. If an array or object throws
// while setting a value, that property or item is skipped, leaving a hole in
// the case of arrays.
+ // TODO(dcheng): This should just take a const reference.
virtual v8::Local<v8::Value> ToV8Value(
const base::Value* value,
v8::Local<v8::Context> context) const = 0;
@@ -118,6 +119,7 @@ class CONTENT_EXPORT V8ValueConverter {
// Likewise, if an object throws while converting a property it will not be
// converted, whereas if an array throws while converting an item it will be
// converted to Value(TYPE_NULL).
+ // TODO(dcheng): This should return a unique_ptr.
virtual base::Value* FromV8Value(v8::Local<v8::Value> value,
v8::Local<v8::Context> context) const = 0;
};

Powered by Google App Engine
This is Rietveld 408576698