Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chromeos/network/prohibited_technologies_handler.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/prohibited_technologies_handler.cc
diff --git a/chromeos/network/prohibited_technologies_handler.cc b/chromeos/network/prohibited_technologies_handler.cc
index 5d41e31264e163e9a23092a0034b413c6f778c33..643714e4de99893819e9b4286e36d56939eacbb5 100644
--- a/chromeos/network/prohibited_technologies_handler.cc
+++ b/chromeos/network/prohibited_technologies_handler.cc
@@ -63,9 +63,10 @@ void ProhibitedTechnologiesHandler::SetProhibitedTechnologies(
// Build up prohibited network type list and save it for furthur use when
// enforced
prohibited_technologies_.clear();
- for (const base::Value* item : *prohibited_list) {
+ for (const auto& item : *prohibited_list) {
std::string prohibited_technology;
- item->GetAsString(&prohibited_technology);
+ if (!item->GetAsString(&prohibited_technology))
danakj 2016/05/24 20:08:35 nitto?
+ NOTREACHED();
std::string translated_tech =
network_util::TranslateONCTypeToShill(prohibited_technology);
if (!translated_tech.empty())

Powered by Google App Engine
This is Rietveld 408576698