Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

content/public/child/v8_value_converter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_CHILD_V8_VALUE_CONVERTER_H_
 #define CONTENT_PUBLIC_CHILD_V8_VALUE_CONVERTER_H_
 
 #include "base/callback.h"
 #include "content/common/content_export.h"
 #include "v8/include/v8.h"
@@ skipping 87 matching lines @@
   virtual void SetStripNullFromObjects(bool val) = 0;
 
   // Extend default behavior of V8ValueConverter.
   virtual void SetStrategy(Strategy* strategy) = 0;
 
   // Converts a base::Value to a v8::Value.
   //
   // Unsupported types are replaced with null.  If an array or object throws
   // while setting a value, that property or item is skipped, leaving a hole in
   // the case of arrays.
+  // TODO(dcheng): This should just take a const reference.
   virtual v8::Local<v8::Value> ToV8Value(
       const base::Value* value,
       v8::Local<v8::Context> context) const = 0;
 
   // Converts a v8::Value to base::Value.
   //
   // Unsupported types (unless explicitly configured) are not converted, so
   // this method may return NULL -- the exception is when converting arrays,
   // where unsupported types are converted to Value(TYPE_NULL).
   //
   // Likewise, if an object throws while converting a property it will not be
   // converted, whereas if an array throws while converting an item it will be
   // converted to Value(TYPE_NULL).
+  // TODO(dcheng): This should return a unique_ptr.
   virtual base::Value* FromV8Value(v8::Local<v8::Value> value,
                                    v8::Local<v8::Context> context) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_CHILD_V8_VALUE_CONVERTER_H_