content/browser/media/webrtc/webrtc_internals.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc/webrtc_internals.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/prohibited_technologies_handler.cc ('K') | « content/browser/android/java/gin_java_method_invocation_helper.cc ('k') | content/public/child/v8_value_converter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc/webrtc_internals.cc

diff --git a/content/browser/media/webrtc/webrtc_internals.cc b/content/browser/media/webrtc/webrtc_internals.cc

index 09d7a970d26052e49cedf927f7bf87711bfb1c1a..29fbbb5be547d818c98dba49ba8fd9da47ed1673 100644

--- a/content/browser/media/webrtc/webrtc_internals.cc

+++ b/content/browser/media/webrtc/webrtc_internals.cc

@@ -263,10 +263,8 @@ void WebRTCInternals::UpdateObserver(WebRTCInternalsUIObserver* observer) {

if (peer_connection_data_.GetSize() > 0)

observer->OnUpdate("updateAllPeerConnections", &peer_connection_data_);

- for (base::ListValue::iterator it = get_user_media_requests_.begin();

- it != get_user_media_requests_.end();

- ++it) {

- observer->OnUpdate("addGetUserMedia", *it);

+ for (const auto& request : get_user_media_requests_) {

+ observer->OnUpdate("addGetUserMedia", request.get());

}