Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7997)

Unified Diff: chrome/test/chromedriver/performance_logger.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/performance_logger.cc
diff --git a/chrome/test/chromedriver/performance_logger.cc b/chrome/test/chromedriver/performance_logger.cc
index 4b264546756044ba1b50bb898ea4271e9b1fc64a..e67074fb645eac0fb74ffc86c67f7f4294f45cc4 100644
--- a/chrome/test/chromedriver/performance_logger.cc
+++ b/chrome/test/chromedriver/performance_logger.cc
@@ -181,7 +181,7 @@ Status PerformanceLogger::HandleTraceEvents(
return Status(kUnknownError,
"received DevTools trace data in unexpected format");
}
- for (base::Value* const trace : *traces) {
+ for (const auto& trace : *traces) {
base::DictionaryValue* event_dict;
if (!trace->GetAsDictionary(&event_dict))
return Status(kUnknownError, "trace event must be a dictionary");

Powered by Google App Engine
This is Rietveld 408576698