chrome/service/cloud_print/printer_job_queue_handler.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/printer_job_queue_handler.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/certificates_handler.cc ('K') | « chrome/common/extensions/manifest_handlers/linked_app_icons.cc ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | chromeos/network/onc/onc_mapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/printer_job_queue_handler.cc

diff --git a/chrome/service/cloud_print/printer_job_queue_handler.cc b/chrome/service/cloud_print/printer_job_queue_handler.cc

index 0b5ecaa18f6b9d3fee413d46400a5a74c51f938b..4757bd9344a49a97fbb6905ce41c2f6c246199df 100644

--- a/chrome/service/cloud_print/printer_job_queue_handler.cc

+++ b/chrome/service/cloud_print/printer_job_queue_handler.cc

@@ -118,7 +118,7 @@ std::vector<JobDetails> PrinterJobQueueHandler::GetJobsFromQueue(

return jobs;

std::vector<JobDetails> jobs_with_timeouts;

- for (const auto* job_value : *job_list) {

+ for (const auto& job_value : *job_list) {

const base::DictionaryValue* job_data = nullptr;

if (!job_value->GetAsDictionary(&job_data))

continue;