Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3116)

Unified Diff: chrome/service/cloud_print/printer_job_queue_handler.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/printer_job_queue_handler.cc
diff --git a/chrome/service/cloud_print/printer_job_queue_handler.cc b/chrome/service/cloud_print/printer_job_queue_handler.cc
index 0b5ecaa18f6b9d3fee413d46400a5a74c51f938b..4757bd9344a49a97fbb6905ce41c2f6c246199df 100644
--- a/chrome/service/cloud_print/printer_job_queue_handler.cc
+++ b/chrome/service/cloud_print/printer_job_queue_handler.cc
@@ -118,7 +118,7 @@ std::vector<JobDetails> PrinterJobQueueHandler::GetJobsFromQueue(
return jobs;
std::vector<JobDetails> jobs_with_timeouts;
- for (const auto* job_value : *job_list) {
+ for (const auto& job_value : *job_list) {
const base::DictionaryValue* job_data = nullptr;
if (!job_value->GetAsDictionary(&job_data))
continue;

Powered by Google App Engine
This is Rietveld 408576698