chromeos/network/onc/onc_mapper.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_mapper.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/certificates_handler.cc ('K') | « chromeos/network/network_util.cc ('k') | chromeos/network/onc/onc_utils.cc » ('j') | chromeos/network/onc/onc_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/onc/onc_mapper.cc

diff --git a/chromeos/network/onc/onc_mapper.cc b/chromeos/network/onc/onc_mapper.cc

index d5df15ef23c4a9465fa590be0c77f4260e306d2e..1da58015c39f6b44354f8e4ea7fbb14e44da0210 100644

--- a/chromeos/network/onc/onc_mapper.cc

+++ b/chromeos/network/onc/onc_mapper.cc

@@ -116,10 +116,7 @@ std::unique_ptr<base::ListValue> Mapper::MapArray(

std::unique_ptr<base::ListValue> result_array(new base::ListValue);

int original_index = 0;

- for (base::ListValue::const_iterator it = onc_array.begin();

- it != onc_array.end(); ++it, ++original_index) {

- const base::Value* entry = *it;

+ for (const auto& entry : onc_array) {

danakj 2016/05/24 20:08:35 You need to ++original_index still. wtb unit tests

dcheng 2016/05/24 20:39:02 Done. Clever code is clever.

std::unique_ptr<base::Value> result_entry;

result_entry = MapEntry(original_index,

*array_signature.onc_array_entry_signature,

« chrome/browser/ui/webui/settings/certificates_handler.cc ('K') | « chromeos/network/network_util.cc ('k') | chromeos/network/onc/onc_utils.cc » ('j') | chromeos/network/onc/onc_utils.cc » ('J')