chrome/utility/importer/nss_decryptor.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/nss_decryptor.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/certificates_handler.cc ('K') | « chrome/test/chromedriver/performance_logger.cc ('k') | chromeos/network/network_util.cc » ('j') | chromeos/network/onc/onc_mapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/nss_decryptor.cc

diff --git a/chrome/utility/importer/nss_decryptor.cc b/chrome/utility/importer/nss_decryptor.cc

index 3f3d83834f5a08e2c3b5481c5e9064265340e4e5..af7e8478e157d3467d44dc878d387be1b5afa135 100644

--- a/chrome/utility/importer/nss_decryptor.cc

+++ b/chrome/utility/importer/nss_decryptor.cc

@@ -304,7 +304,7 @@ bool NSSDecryptor::ReadAndParseLogins(

return false;

if (password_dict->GetList("disabledHosts", &blacklist_domains)) {

- for (const base::Value* value : *blacklist_domains) {

+ for (const auto& value : *blacklist_domains) {

std::string disabled_host;

if (!value->GetAsString(&disabled_host))

continue;

@@ -313,7 +313,7 @@ bool NSSDecryptor::ReadAndParseLogins(

}

if (password_dict->GetList("logins", &password_list)) {

- for (const base::Value* value : *password_list) {

+ for (const auto& value : *password_list) {

const base::DictionaryValue* password_detail;

if (!value->GetAsDictionary(&password_detail))

continue;