Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1999343002: Unify and provide one IsGarbageCollectedType<T> implementation. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, blink-reviews-wtf_chromium.org, pdr+svgwatchlist_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-css, szager+layoutwatch_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, rwlbuis, ajuma+watch_chromium.org, Mads Ager (chromium), zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, darktears, danakj+watch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify and provide one IsGarbageCollectedType<T> implementation. Phase out the need and use of the older blink::IsGarbageCollected<T> template, and go with the "marker-based" implementation that WTF provides. But extended slightly to handle mixins without ambiguity + it will now insist on T's definition being in scope when used so as to be able to function reliably. That latter change requires a few uses of collection types (vectors, hash maps) to be adjusted so that the full element type of the collection is in scope when code using the collection is compiled. The reason for this constraint is that the collection types stringently checks that Blink GCed objects aren't kept in off-heap collections. R= BUG= Committed: https://crrev.com/1cfb1e02887a0157e3214e3886c39ce0966e1be5 Cr-Commit-Position: refs/heads/master@{#395287}

Patch Set 1 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -107 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/OnStackObjectChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/OnStackObjectChecker.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 4 chunks +2 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 2 chunks +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 2 chunks +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraits.h View 2 chunks +29 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (13 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-22 13:00:28 UTC) #3
haraken
LGTM
4 years, 7 months ago (2016-05-22 14:35:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999343002/20001
4 years, 7 months ago (2016-05-22 14:37:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999343002/20001
4 years, 7 months ago (2016-05-22 15:53:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233485)
4 years, 7 months ago (2016-05-22 17:24:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999343002/20001
4 years, 7 months ago (2016-05-22 18:13:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233498)
4 years, 7 months ago (2016-05-22 20:42:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999343002/20001
4 years, 7 months ago (2016-05-22 20:44:44 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233500)
4 years, 7 months ago (2016-05-22 23:13:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999343002/20001
4 years, 7 months ago (2016-05-23 04:59:52 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 06:07:23 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 06:08:22 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cfb1e02887a0157e3214e3886c39ce0966e1be5
Cr-Commit-Position: refs/heads/master@{#395287}

Powered by Google App Engine
This is Rietveld 408576698