Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 1999343002: Unify and provide one IsGarbageCollectedType<T> implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 80
81 void CellSpan::ensureConsistency(const unsigned maximumSpanSize) 81 void CellSpan::ensureConsistency(const unsigned maximumSpanSize)
82 { 82 {
83 static_assert(std::is_same<decltype(m_start), unsigned>::value, "Asserts bel ow assume m_start is unsigned"); 83 static_assert(std::is_same<decltype(m_start), unsigned>::value, "Asserts bel ow assume m_start is unsigned");
84 static_assert(std::is_same<decltype(m_end), unsigned>::value, "Asserts below assume m_end is unsigned"); 84 static_assert(std::is_same<decltype(m_end), unsigned>::value, "Asserts below assume m_end is unsigned");
85 RELEASE_ASSERT(m_start <= maximumSpanSize); 85 RELEASE_ASSERT(m_start <= maximumSpanSize);
86 RELEASE_ASSERT(m_end <= maximumSpanSize); 86 RELEASE_ASSERT(m_end <= maximumSpanSize);
87 RELEASE_ASSERT(m_start <= m_end); 87 RELEASE_ASSERT(m_start <= m_end);
88 } 88 }
89 89
90 LayoutTableSection::CellStruct::CellStruct()
91 : inColSpan(false)
92 {
93 }
94
95 LayoutTableSection::CellStruct::~CellStruct()
96 {
97 }
98
90 LayoutTableSection::LayoutTableSection(Element* element) 99 LayoutTableSection::LayoutTableSection(Element* element)
91 : LayoutTableBoxComponent(element) 100 : LayoutTableBoxComponent(element)
92 , m_cCol(0) 101 , m_cCol(0)
93 , m_cRow(0) 102 , m_cRow(0)
94 , m_outerBorderStart(0) 103 , m_outerBorderStart(0)
95 , m_outerBorderEnd(0) 104 , m_outerBorderEnd(0)
96 , m_outerBorderBefore(0) 105 , m_outerBorderBefore(0)
97 , m_outerBorderAfter(0) 106 , m_outerBorderAfter(0)
98 , m_needsCellRecalc(false) 107 , m_needsCellRecalc(false)
99 , m_forceSlowPaintPathWithOverflowingCell(false) 108 , m_forceSlowPaintPathWithOverflowingCell(false)
(...skipping 1555 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691). 1664 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691).
1656 if (!style()->isLeftToRightDirection()) 1665 if (!style()->isLeftToRightDirection())
1657 cellLocation.setX(LayoutUnit(table()->effectiveColumnPositions()[table() ->numEffectiveColumns()] - table()->effectiveColumnPositions()[table()->absolute ColumnToEffectiveColumn(cell->absoluteColumnIndex() + cell->colSpan())] + horizo ntalBorderSpacing)); 1666 cellLocation.setX(LayoutUnit(table()->effectiveColumnPositions()[table() ->numEffectiveColumns()] - table()->effectiveColumnPositions()[table()->absolute ColumnToEffectiveColumn(cell->absoluteColumnIndex() + cell->colSpan())] + horizo ntalBorderSpacing));
1658 else 1667 else
1659 cellLocation.setX(LayoutUnit(table()->effectiveColumnPositions()[effecti veColumn] + horizontalBorderSpacing)); 1668 cellLocation.setX(LayoutUnit(table()->effectiveColumnPositions()[effecti veColumn] + horizontalBorderSpacing));
1660 1669
1661 cell->setLogicalLocation(cellLocation); 1670 cell->setLogicalLocation(cellLocation);
1662 } 1671 }
1663 1672
1664 } // namespace blink 1673 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698